Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that
 depend on the range column
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CA+renyU6rNkiNGreMyQ7pU_F6-5RND5jchHbECH4NoRO7W0Q-Q@mail.gmail.com>
Date: Thu, 7 May 2026 12:34:43 +0800
Cc: Peter Eisentraut <peter@eisentraut.org>,
 jian he <jian.universality@gmail.com>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <27BD5D23-19C9-4FD1-8935-9C788C3C9869@gmail.com>
References: 
 <CAHg+QDcd=t69gLf9yQexO07EJ2mx0Z70NFHo6h94X1EDA=hM0g@mail.gmail.com>
 <CACJufxGreOtA-S-qeHyS5iSSsj5zZX0W3Rf8FxbyL+SVXFjLYw@mail.gmail.com>
 <CAHg+QDeGLfz8YSCChjqrxaVSrz9AnMA0NrmsNogLqeGgCt7-wg@mail.gmail.com>
 <CA+renyWD+XXifwswE74vhjooqbiVKu4qVhLvpMcUQBzrjVjT7A@mail.gmail.com>
 <CACJufxHYntqy2fo9CFWDDrqKjcMK8DGRM3kse4YnXYnPYq2Hiw@mail.gmail.com>
 <CA+renyVp4rgj8x0ERXRkZp223eyBZ_XZr2RVCXvjzKBhTtS6Yw@mail.gmail.com>
 <CACJufxEkomKYmWgqXJmQr_qS+z=BZ3w801eh7Z7ekh-3oHXxHQ@mail.gmail.com>
 <CA+renyWk7kVsZJPZKzN95mYkO7S=hDUx=+fUPtbg9qFqeepCpg@mail.gmail.com>
 <CACJufxHai+HB1gkNqVEHe4oKyUmXfAagWBYAWXYKy8hyMV3RxA@mail.gmail.com>
 <CA+renyUBQdhnYxfPay+dxFs6BU1-fnEQskT0r-3dQ2v-ZnmZzg@mail.gmail.com>
 <CA+renyVZLYSghHb_85w0pUBG0KNGKTwciFTKBK5--rpHUM+VdA@mail.gmail.com>
 <e856c439-bf96-4244-8dc3-18b2a552e406@eisentraut.org>
 <CA+renyU6rNkiNGreMyQ7pU_F6-5RND5jchHbECH4NoRO7W0Q-Q@mail.gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Archived-At: 
 <https://www.postgresql.org/message-id/27BD5D23-19C9-4FD1-8935-9C788C3C9869%40gmail.com>
Precedence: bulk


> On May 7, 2026, at 01:13, Paul A Jungwirth =
<pj@illuminatedcomputing.com> wrote:
>=20
> On Wed, May 6, 2026 at 4:39=E2=80=AFAM Peter Eisentraut =
<peter@eisentraut.org> wrote:
>>=20
>> On 05.05.26 23:50, Paul A Jungwirth wrote:
>>> On Wed, Apr 22, 2026 at 11:03=E2=80=AFAM Paul A Jungwirth
>>> <pj@illuminatedcomputing.com> wrote:
>>>>=20
>>>> Good catch! I removed that line in v7 (attached). I also included =
your
>>>> test change to compute the range len by hand. Also a rebase was
>>>> necessary after d3bba04154.
>>>=20
>>> This needed a rebase. v8 attached.
>>=20
>> This patch fails the injection_points/isolation test for me.  It =
looks
>> like it causes a server crash.  Check please.
>=20
> Sorry, I didn't have injection_points enabled, but now I see it too.
> The attached v9 fixes it.
>=20
> Yours,
>=20
> --=20
> Paul              ~{:-)
> pj@illuminatedcomputing.com
> <v9-0001-Fix-some-problems-with-UPDATE-FOR-PORTION-OF.patch>

Hi Paul,

I didn=E2=80=99t review this patch earlier because, from the subject, I =
thought it was only about recomputing generated stored columns. I just =
noticed that the patch also changes the inheritance-table path, and I =
posted another patch for the inheritance-table bug. Please see [1].

I tried applying the new tests from my patch on top of this patch, and =
it looks like this patch still does not fix the multi-inheritance case.

So I=E2=80=99d like to check with you how we should proceed. I think =
there are two options:

1. Keep this patch focused on the generated-column issue described in =
the subject, and use my patch to fix the inheritance-table bug.
2. I can continue from this patch and extend it to fix the =
multi-inheritance case as well.

Please let me know what you prefer.

[1] =
https://www.postgresql.org/message-id/4245F94D-84F1-4E05-BF81-C458A6CF9901=
%40gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/