Content-Type: multipart/mixed; boundary="------------SgOjZeCyzuSgVrNd2BlLAV4R"
Message-ID: <27a7998b-d67f-e32a-a28d-e659a2e390c6@gmail.com>
Date: Fri, 3 Nov 2023 09:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Three commit tips
Content-Language: en-US
To: Bruce Momjian <bruce@momjian.us>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <ZUO-vjLa-Bb4a2VD@momjian.us>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <ZUO-vjLa-Bb4a2VD@momjian.us>
Archived-At: <https://www.postgresql.org/message-id/27a7998b-d67f-e32a-a28d-e659a2e390c6%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------SgOjZeCyzuSgVrNd2BlLAV4R
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

02.11.2023 18:22, Bruce Momjian wrote:
> Third, I have come up with the following shell script to test for proper
> pgindentation, which I run automatically before commit:

I would also suggest using a script like attached to check a patch for
new unicums (usually some of them are typos or inconsistencies introduced
by the patch).
The script itself can be improved, without a doubt, but it still can be
useful as-is. For example, for a couple of arbitrarily chosen today's
patches [1] it shows:

.../postgresql.git$ check-patch-for-unicums.sh .../v4-0001-Make-all-SLRU-buffer-sizes-configurable.patch
New unicums:
cotents:        ./doc/src/sgml/config.sgml:        Specifies the amount of memory to use to cache the cotents of
====

.../postgresql.git$ check-patch-for-unicums.sh .../v4-0003-Partition-wise-slru-locks.patch
New unicums:
bank_tranche_id: ./src/include/access/slru.h: int bank_tranche_id, SyncRequestHandler sync_handler);
CommitTSSLRU:   ./src/backend/storage/lmgr/lwlock.c: "CommitTSSLRU",
CommitTsSLRULock: ./src/backend/storage/lmgr/lwlocknames.txt:#38 was CommitTsSLRULock
ControlLock:    ./src/backend/replication/slot.c:        * flag while holding the ControlLock as otherwise a concurrent
ctllock:        ./src/backend/access/transam/slru.c: * ctllock: LWLock to use to control access to the shared control 
structure.
cur_lru_count:  ./src/backend/access/transam/slru.c:             * Notice that this next line forcibly advances 
cur_lru_count to a
...

[1] https://www.postgresql.org/message-id/CAFiTN-uyiUXU__VwJAimZ%2B6jQbm1s4sYi6u4fXBD%3D47xVd%3Dthg%40mail.gmail.com

Best regards,
Alexander
--------------SgOjZeCyzuSgVrNd2BlLAV4R
Content-Type: application/x-shellscript; name="check-patch-for-unicums.sh"
Content-Disposition: attachment; filename="check-patch-for-unicums.sh"
Content-Transfer-Encoding: base64

IyEvYmluL2Jhc2gKCnNldCAtZQoKaWYgWyAteiAiJDEiIF07IHRoZW4KICAgIGVjaG8gIlVz
YWdlOiAkMCBzb21lLnBhdGNoIgogICAgZWNobyAiQ2hlY2sgdGhlIHBhdGNoIGZvciBuZXcg
dW5pY3Vtcy4iCiAgICBlY2hvICJFeGFtcGxlOiAkMCBuZXctZmVhdHVyZS5wYXRjaCIKICAg
IGV4aXQgMQpmaQoKcGF0Y2g9IiQxIgoKZnVuY3Rpb24gZXh0cmFjdF91bmljdW1zIHsKICAg
IHN0YXRlX2lkPSQxCiAgICBmaW5kIC4gLXR5cGUgZiBcISAtcGF0aCAnLi8uZ2l0LyonIFwh
IC1wYXRoICcuLy5naXQtYmxhbWUtaWdub3JlLXJldnMnIFwKICAgICBcISAtbmFtZSAnKi5w
bycgXCEgLW5hbWUgJyouc3RvcCcgXCEgLW5hbWUgJyouZGF0YScgXCEgLW5hbWUgJyouZGlj
dCcgXCEgLW5hbWUgJyouYWZmaXgnIFwKICAgICBcISAtcGF0aCAnLi9zcmMvYmFja2VuZC9j
YXRhbG9nL3NxbF9mZWF0dXJlcy50eHQnIFwKICAgICBcISAtcGF0aCAnLi9zcmMvYmFja2Vu
ZC91dGlscy9lcnJjb2Rlcy50eHQnIFwKICAgICBcISAtcGF0aCAnLi9zcmMvYmFja2VuZC91
dGlscy9mbWdyb2lkcy5oJyBcCiAgICAgXCEgLXBhdGggJy4vc3JjL2JhY2tlbmQvdXRpbHMv
bWIvVW5pY29kZS8qJyBcCiAgICAgXCEgLXBhdGggJy4vc3JjL2ludGVyZmFjZXMvZWNwZy9w
cmVwcm9jL3ByZXByb2MuYycgXAogICAgIFwhIC1wYXRoICcuL3NyYy9wbC9wbHBlcmwvcHBw
b3J0LmgnIFwKICAgICBcISAtcGF0aCAnLi9zcmMvcG9ydC93aW4zMi5pY28nIFwKICAgICBc
ISAtcGF0aCAnLi9zcmMvdGVzdC9zc2wvc3NsLyonIFwKICAgICBcISAtcGF0aCAnLi9zcmMv
dGltZXpvbmUvZGF0YS90emRhdGEuemknIFwKICAgICBcISAtcGF0aCAnLi9zcmMvdG9vbHMv
cGdpbmRlbnQvdHlwZWRlZnMubGlzdCcgXAogICAgIC1leGVjIGdyZXAgLW8gLVAgJ1xiW2Et
ekEtWl9dW2EtekEtWjAtOS1fXSsnIHt9IFw7IHwgc2VkICdzLy1cKyQvL2c7L14uJC9kJyB8
IFwKICAgICBzb3J0ID4iJFdEL2VudGl0aWVzLXNvcnRlZC0kc3RhdGVfaWQudHh0IgogICAg
dW5pcSAtdSAiJFdEL2VudGl0aWVzLXNvcnRlZC0kc3RhdGVfaWQudHh0IiA+IiRXRC91bmlj
dW1zLSRzdGF0ZV9pZC50eHQiCn0KCldEPSIke1RNUERJUjotL3RtcH0iCgpleHRyYWN0X3Vu
aWN1bXMgdW5wYXRjaGVkCgpwYXRjaCAtcDEgLWkgIiRwYXRjaCIgPi9kZXYvbnVsbAoKZXh0
cmFjdF91bmljdW1zIHBhdGNoZWQKCmVjaG8gIk5ldyB1bmljdW1zOiIKZGlmZiAtLWNoYW5n
ZWQtZ3JvdXAtZm9ybWF0PSclPicgLS11bmNoYW5nZWQtZ3JvdXAtZm9ybWF0PScnICIkV0Qv
dW5pY3Vtcy11bnBhdGNoZWQudHh0IiAiJFdEL3VuaWN1bXMtcGF0Y2hlZC50eHQiID4gIiRX
RC9uZXctdW5pY3Vtcy50eHQiIHx8IHRydWUKd2hpbGUgSUZTPSByZWFkIC1yIHc7IGRvCiAg
Z3JlcCAtcSAiXGJpZD1cIiR3XCIiIC1yIGRvYy8gJiYgY29udGludWUKICBlY2hvIC1lIC1u
ICIkdzpcdCIKICBncmVwIC1QICJcYiR3XGIiIC1yIC4vKiAuY2lycnVzLnltbCBcCiAgICAt
LWV4Y2x1ZGU9JyoucG8nIC0tZXhjbHVkZT0nKi5zdG9wJyAtLWV4Y2x1ZGU9JyouZGF0YScg
XAogICAgLS1leGNsdWRlPScqLmRpY3QnIC0tZXhjbHVkZT0nKi5hZmZpeCcgLS1leGNsdWRl
PSd0eXBlZGVmcy5saXN0JyBcCiAgICAtLWV4Y2x1ZGU9J2diLTE4MDMwLTIwMDAueG1sJyBc
CiAgICAtLWNvbG9yPWF1dG8gfHwgdHJ1ZQpkb25lIDwgIiRXRC9uZXctdW5pY3Vtcy50eHQi
CmVjaG8gIj09PT0iCg==

--------------SgOjZeCyzuSgVrNd2BlLAV4R--