From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org, obartunov@gmail.com
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Opclass parameters
Date: Fri, 02 Mar 2018 19:12:58 +0300
Message-ID: <2803786.3sFNWAn8Pn@x200m>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: 
 <CAF4Au4xedPHJQyN60x+6giMpEyLdKn7jFR85_kzaApy9BptRUw@mail.gmail.com>
References: <d22c3a18-31c7-1879-fc11-4c1ce2f5e5af@postgrespro.ru>
 <15077864.qMPJiTemUy@x200m>
 <CAF4Au4xedPHJQyN60x+6giMpEyLdKn7jFR85_kzaApy9BptRUw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1623349.crhsu5P42u";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk


--nextPart1623349.crhsu5P42u
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 1 =D0=BC=D0=B0=
=D1=80=D1=82=D0=B0 2018 23:02:20 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=
=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Oleg Bartunov =D0=BD=D0=B0=D0=BF=D0=B8=
=D1=81=D0=B0=D0=BB:

> > 2. Your patch does not provide any example of your new tool usage. =
In my
> > prototype patch I've shown the implementation of opclass options fo=
r
> > intarray. May be you should do the same. (Use my example it will be=
 more
> > easy then do it from scratch). It will give more understanding of h=
ow
> > this improvement can be used.
>=20
> Hey, look on patches, there are many examples  !
Oups...Sorry. I've looked at the patch from commitfest=20
https://commitfest.postgresql.org/17/1559/ and it have shown only the f=
irst=20
file. And When I read the letter I did not pay attention to attachments=
 at=20
all. So I was sure there is only one there.

Yes. Now I see seven examples. But I think seven it is too many.
For each case a reviewer should make consideration if this parameter wo=
rth=20
moving to opclass options, or fixed definition in the C code is quite o=
k.=20
Doing it for whole bunch, may make it messy. I think, it would be good =
to=20
commit an implementation of opclass options, with a good example of usa=
ge. And=20
then commit patches for all cases where these options can be used.=20

But since it is now "Rejected with feedback", let's wait till autumn.=20=


=2D-=20
Do code for fun.
--nextPart1623349.crhsu5P42u
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJamXgKAAoJEKc13HowK+H4JEQH/3O4rNDbXMqSqgAJHWOMKuvj
pg9AHgUTL+85pbiZ5SeommC2zEpnv0cWGNhQPSsg5JpXcgCvEiglmiYLh/4CZfOb
MgJislBa1NFANQW+RooY/vZL7ruWZXF8oVxBn8qzgMeS/tJvGFiJRRXv3T20YPAy
UeMrhEzB03wL2fMLlw9r+nFxeJGrsujKfNXUrr3wfkoX8SWqyS3mrf3lGtiynCfH
VdAtNIcE9gZs+aGpaMIymzD+USQAKOegHQYiKL+azZzWYt5iMOXPAhWi8gso0k1z
dSLwLtjeDU4ay3oCxT0dwFqSlg5Pca4/y5jwK50GCQ+piivG8RhWTuz0XKdaM9k=
=03xK
-----END PGP SIGNATURE-----

--nextPart1623349.crhsu5P42u--