Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmnNw-00025t-Vk for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2022 02:08:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nmnNu-0001Wo-Gk for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2022 02:07:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmnNu-0001WZ-8A for pgsql-hackers@lists.postgresql.org; Fri, 06 May 2022 02:07:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmnNh-0002Rj-M8 for pgsql-hackers@postgresql.org; Fri, 06 May 2022 02:07:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 24627e182808492; Thu, 5 May 2022 22:07:40 -0400 From: Tom Lane To: Andres Freund cc: Robert Haas , pgsql-hackers@postgresql.org, Thomas Munro Subject: Re: failures in t/031_recovery_conflict.pl on CI In-reply-to: <20220503191305.htuzje6ldmic7skk@alap3.anarazel.de> References: <907760.1649790322@sss.pgh.pa.us> <20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de> <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de> <465685.1651274819@sss.pgh.pa.us> <20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de> <1929823.1651549472@sss.pgh.pa.us> <20220503040557.eimbfibv4rsey3s5@alap3.anarazel.de> <1959496.1651555006@sss.pgh.pa.us> <20220503182025.wvbebs2ojk6vpi5f@alap3.anarazel.de> <2174975.1651602203@sss.pgh.pa.us> <20220503191305.htuzje6ldmic7skk@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 03 May 2022 12:13:05 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2808490.1651802860.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 05 May 2022 22:07:40 -0400 Message-ID: <2808491.1651802860@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Attached is a fix for the test that I think should avoid the problem. Co= uldn't > repro it with it applied, under both rr and valgrind. May I ask where we're at on this? Next week's back-branch release is getting uncomfortably close, and I'm still seeing various buildfarm animals erratically failing on 031_recovery_conflict.pl. Should we just remove that test from the back branches for now? Also, it appears that the back-patch of pump_until failed to remove some pre-existing copies, eg check-world in v14 now reports Subroutine pump_until redefined at t/013_crash_restart.pl line 248. Subroutine pump_until redefined at t/022_crash_temp_files.pl line 272. I didn't check whether these are exact duplicates. regards, tom lane