From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        Aleksander Alekseev <aleksander@timescale.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: The documentation for READ COMMITTED may be incomplete or wrong
In-reply-to: <CA+HiwqFKUruFL8=njk1WkDCNo3PrxWuL9o9DQ_BJitBw0Dpr3Q@mail.gmail.com>
References: <CAJ7c6TMBTN3rcz4=AjYhLPD_w3FFT0Wq_C15jxCDn8U4tZnH1g@mail.gmail.com> <3794290.1684421615@sss.pgh.pa.us> <3798164.1684423374@sss.pgh.pa.us> <20230518195123.GA3362715@nathanxps13> <3880859.1684440216@sss.pgh.pa.us> <20230518213442.GA3364784@nathanxps13> <4024583.1684448782@sss.pgh.pa.us> <4111741.1684454234@sss.pgh.pa.us> <CA+HiwqFKUruFL8=njk1WkDCNo3PrxWuL9o9DQ_BJitBw0Dpr3Q@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Fri, 19 May 2023 21:53:45 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <281323.1684521216.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 19 May 2023 14:33:36 -0400
Message-ID: <281324.1684521216@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/281324.1684521216%40sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> On Fri, May 19, 2023 at 8:57 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What I'm thinking about doing to back-patch this is to replace
>> one of the pointer fields in EPQState with a pointer to a
>> subsidiary palloc'd structure, where we can put the new fields
>> along with the cannibalized old one.  We've done something
>> similar before, and it seems a lot safer than having basically
>> different logic in v16 than earlier branches.

> +1.

Done that way.  I chose to replace the tuple_table field, because
it was in a convenient spot and it seemed like the field least
likely to have any outside code referencing it.

			regards, tom lane