Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsnEH-009Rgs-T4 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:47:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qsnEF-00CQoP-FK for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:47:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsnEF-00CQnt-66 for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 16:47:35 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsnEC-001D7P-49 for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 16:47:35 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39HGlTLR2820646; Tue, 17 Oct 2023 12:47:29 -0400 From: Tom Lane To: Nathan Bossart cc: Michael Paquier , Andres Freund , Thomas Munro , Robert Haas , Fujii Masao , Postgres hackers Subject: Re: stopgap fix for signal handling during restore_command In-reply-to: <20231017164517.GA613565@nathanxps13> References: <20230226201227.cner3cdicropu4q5@awork3.anarazel.de> <20230301043603.GD1453450@nathanxps13> <20230301224751.GA1823946@nathanxps13> <20231010234028.iba6wotmp22poxoh@awork3.anarazel.de> <20231011025418.GA845134@nathanxps13> <20231011032934.GA847236@nathanxps13> <20231011033929.j7doct7wzmyw6xiu@awork3.anarazel.de> <20231011190000.GA894647@nathanxps13> <20231017154647.GA611717@nathanxps13> <20231017164517.GA613565@nathanxps13> Comments: In-reply-to Nathan Bossart message dated "Tue, 17 Oct 2023 11:45:17 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2820644.1697561249.1@sss.pgh.pa.us> Date: Tue, 17 Oct 2023 12:47:29 -0400 Message-ID: <2820645.1697561249@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > ... and it looks like some of the back-branches are failing for Windows. > I'm assuming this is because c290e79 was only back-patched to v15. My > first instinct is just to back-patch that one all the way to v11, but maybe > there's an alternative involving #ifdef WIN32. Are there any concerns with > back-patching c290e79? Sounds fine to me. regards, tom lane