From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Evan Jones <evan.jones@datadoghq.com>, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
In-reply-to: <ZI+TK2kch0ZZ/Amk@paquier.xyz>
References: <CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com> <ZH8aia7JfdPjTKAY@paquier.xyz> <CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com> <ZIZkMf6rfCVQaKgO@paquier.xyz> <CA+HWA9bTRDf52DHyU+JOoqEALgRGRo5uHUYTFuduoj3cBfer+Q@mail.gmail.com> <ZI5i2NCWirDuE/Iq@paquier.xyz> <ZI7BD6jTsn4vdCxe@paquier.xyz> <2765603.1687106292@sss.pgh.pa.us> <ZI+TK2kch0ZZ/Amk@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 19 Jun 2023 08:28:43 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2823518.1687137059.1@sss.pgh.pa.us>
Date: Sun, 18 Jun 2023 21:10:59 -0400
Message-ID: <2823519.1687137059@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2823519.1687137059%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Another thing that I was wondering, though..  Do you think that there
> would be an argument in being stricter in the hstore code regarding
> the handling of multi-byte characters with some checks based on
> IS_HIGHBIT_SET() when parsing the keys and values?

What have you got in mind?  We should already have validated encoding
correctness before the text ever gets to hstore_in, and I'm not clear
what additional checks would be useful.

			regards, tom lane