From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
In-reply-to: <20220506030927.6qehktk6bodv4ft3@alap3.anarazel.de>
References: <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
 <465685.1651274819@sss.pgh.pa.us>
 <20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de>
 <1929823.1651549472@sss.pgh.pa.us>
 <20220503040557.eimbfibv4rsey3s5@alap3.anarazel.de>
 <1959496.1651555006@sss.pgh.pa.us>
 <20220503182025.wvbebs2ojk6vpi5f@alap3.anarazel.de>
 <2174975.1651602203@sss.pgh.pa.us>
 <20220503191305.htuzje6ldmic7skk@alap3.anarazel.de>
 <2808491.1651802860@sss.pgh.pa.us>
 <20220506030927.6qehktk6bodv4ft3@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 05 May 2022 20:09:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2823813.1651808182.1@sss.pgh.pa.us>
Date: Thu, 05 May 2022 23:36:22 -0400
Message-ID: <2823814.1651808182@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2823814.1651808182%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-05-05 22:07:40 -0400, Tom Lane wrote:
>> May I ask where we're at on this?  Next week's back-branch release is
>> getting uncomfortably close, and I'm still seeing various buildfarm
>> animals erratically failing on 031_recovery_conflict.pl.

> Looks like the problems are gone on HEAD at least.

It does look that way, although the number of successes is not large yet.

>> Should we just remove that test from the back branches for now?

> That might be the best course, marking the test as TODO perhaps?

I poked closer and saw that you reverted 5136967f1 et al because
(I suppose) adjust_conf is not there in the back branches.  While
I'd certainly support back-patching that functionality, I think
we need to have a discussion about how to do it.  I wonder whether
we shouldn't drop src/test/perl/PostgreSQL/... into the back branches
in toto and make the old test APIs into a wrapper around the new ones
instead of vice versa.  But that's definitely not a task to undertake
three days before a release deadline.

So I reluctantly vote for removing 031_recovery_conflict.pl in the
back branches for now, with the expectation that we'll fix the
infrastructure and put it back after the current release round
is done.

			regards, tom lane