Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1g7OM4-00042g-91
	for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 17:21:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1g7OM2-0004ni-J1
	for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 17:21:02 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1g7OM2-0004nb-8d
	for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 17:21:02 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1g7OLz-0000mj-S3
	for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 17:21:00 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w92HKwxG028250;
	Tue, 2 Oct 2018 13:20:58 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marco Atzeri <marco.atzeri@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Cygwin linking rules
In-reply-to: <257c24fc-effb-871d-4529-e3ff2ea0d436@gmail.com>
References: <1056.1538235347@sss.pgh.pa.us>
 <86419508-9d36-36a9-93ff-2a051af7d2e4@2ndQuadrant.com>
 <f82cc25e-3404-33b1-3a7b-93e5130e188e@2ndQuadrant.com>
 <257c24fc-effb-871d-4529-e3ff2ea0d436@gmail.com>
Comments: In-reply-to Marco Atzeri <marco.atzeri@gmail.com>
	message dated "Sat, 29 Sep 2018 20:13:25 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28248.1538500858.1@sss.pgh.pa.us>
Date: Tue, 02 Oct 2018 13:20:58 -0400
Message-ID: <28249.1538500858@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Marco Atzeri <marco.atzeri@gmail.com> writes:
> [ cygwin-soversion.diff ]

Oh, one other minor comment on this patch: the rule for the "stlib"
must not be just

$(stlib): $(shlib) ;

Something like this would work:

$(stlib): $(shlib)
	touch $@

See e.g. the AIX case in Makefile.shlib, which is doing about the
same thing.

			regards, tom lane