Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gJLkT-0005GP-8F
	for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Nov 2018 16:59:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gJLkQ-0001gw-KY
	for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Nov 2018 16:59:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gJLkQ-0001gp-9D
	for pgsql-hackers@lists.postgresql.org; Sun, 04 Nov 2018 16:59:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gJLkI-0000Ij-W8
	for pgsql-hackers@postgresql.org; Sun, 04 Nov 2018 16:59:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wA4GxRtB028251;
	Sun, 4 Nov 2018 11:59:27 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: bugfix: BUG #15477: Procedure call with named inout refcursor
 parameter - "invalid input syntax for type boolean"
In-reply-to: 
 <CAFj8pRBYRFqr_ZW+aUnX9MVDme3yBRPGNa0MM=6RR6NV=y2dgg@mail.gmail.com>
References: 
 <CAFj8pRA6UsujpTs9Sdwmk-R6yQykPx46wgjj+YZ7zxm4onrDyw@mail.gmail.com>
 <CAFj8pRBdNqq8+SsChS8F5s9ttkdBSTPu=cq-fLx51FF7Tk_LkA@mail.gmail.com>
 <CAFj8pRCF3pia7gScM0jh7vY9rEuqN7fbnUV+jymRTLEXZeRDNA@mail.gmail.com>
 <CAFj8pRD2=MGU8ZshvmCjv5KG+3EngRm0+8pFLsjhG5bUhUGU2Q@mail.gmail.com>
 <CAFj8pRCehpRXn2vSq8Q+dQL2sQ0XXt0rOukFb0tZ5F7RFdH+DA@mail.gmail.com>
 <1d846492-3822-616b-7246-91b429cc5dbb@2ndquadrant.com>
 <CAFj8pRB3ZPu_SUDamXGA+wXw2aMmn0oLmgvsdMT1oAyJUMgFZA@mail.gmail.com>
 <26116.1541278051@sss.pgh.pa.us> <28551.1541281624@sss.pgh.pa.us>
 <CAFj8pRDUL=nC62L-AKKFDEo1en1ZT1otLfPdXkCjm8MHxif8PA@mail.gmail.com>
 <7102.1541346845@sss.pgh.pa.us>
 <CAFj8pRAcdrRogAC2DU9in=gT1h3y1AgpJnAnDmzho46NS7fJ-w@mail.gmail.com>
 <10615.1541348092@sss.pgh.pa.us>
 <CAFj8pRBYRFqr_ZW+aUnX9MVDme3yBRPGNa0MM=6RR6NV=y2dgg@mail.gmail.com>
Comments: In-reply-to Pavel Stehule <pavel.stehule@gmail.com>
	message dated "Sun, 04 Nov 2018 17:23:11 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28249.1541350767.1@sss.pgh.pa.us>
Date: Sun, 04 Nov 2018 11:59:27 -0500
Message-ID: <28250.1541350767@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Pavel Stehule <pavel.stehule@gmail.com> writes:
> I am not sure how safe is read argmodes from syscache after procedure
> execution. Theoretically, the procedure pg_proc tuple can be modified from
> procedure, and can be committed from procedure. Isn't better to safe
> argmodes before execution?

Hm.  That would mean throwing non-writable-arg errors before rather than
after, but that's probably fine.

			regards, tom lane