From: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, andres@anarazel.de,
    michael@paquier.xyz, pgsql-hackers@postgresql.org
Subject: Re: 2pc leaks fds
In-reply-to: <20200508210916.GA23288@alvherre.pgsql>
References: <20200508210916.GA23288@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
   message dated "Fri, 08 May 2020 17:09:16 -0400."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28249.1589186654.1@antos>
Date: Mon, 11 May 2020 10:44:14 +0200
Message-ID: <28250.1589186654@antos>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> On 2020-May-08, Kyotaro Horiguchi wrote:
> 
> > I agree to the direction of this patch. Thanks for the explanation.
> > The patch looks good to me except the two points below.
> 
> Thanks!  I pushed the patch.

I tried to follow the discussion but haven't had better idea. This looks
better than the previous version. Thanks!

While looking at the changes, I've noticed a small comment issue in the
XLogReaderRoutine structure definition:

	* "tli_p" is an input/output argument. XLogRead() uses it to pass the

The XLogRead() function has been renamed to WALRead() in 0dc8ead4. (This
incorrect comment was actually introduced by that commit.)

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com