Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr6KY-0004Nb-TC for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Mar 2017 17:15:23 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cr6KY-00064K-A2 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Mar 2017 17:15:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cr6KX-00063z-AM for pgsql-hackers@postgresql.org; Thu, 23 Mar 2017 17:15:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cr6KQ-000827-Df for pgsql-hackers@postgresql.org; Thu, 23 Mar 2017 17:15:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2NHEx32028271; Thu, 23 Mar 2017 13:14:59 -0400 From: Tom Lane To: Andres Freund cc: Heikki Linnakangas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: WIP: Faster Expression Processing v4 In-reply-to: <31922.1490194838@sss.pgh.pa.us> References: <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de> <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com> <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de> <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de> <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi> <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de> <13062.1489622943@sss.pgh.pa.us> <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de> <31150.1490193666@sss.pgh.pa.us> <20170322145240.vt2iolwt6vpmx33z@alap3.anarazel.de> <31922.1490194838@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Wed, 22 Mar 2017 11:00:38 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28269.1490289299.1@sss.pgh.pa.us> Date: Thu, 23 Mar 2017 13:14:59 -0400 Message-ID: <28270.1490289299@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Looking at some of the coding choices you made here, I see that you're making a hard assumption that called functions never scribble on their fcinfo->arg/argnull arrays. I do not believe that we've ever had such an assumption before. Are we comfortable with that? If so, we'd better document it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers