From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Noah Misch <noah@leadboat.com>, Bruce Momjian <bruce@momjian.us>,
        Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
References: <20230123173136.knn77pbuakhvjfgk@awork3.anarazel.de>
 <Y874Fh0q4mkk1s22@momjian.us>
 <CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
 <2238493.1674572097@sss.pgh.pa.us> <Y9ArogF7c+UgPgq9@momjian.us>
 <20230129010603.GA1677550@rfd.leadboat.com> <Y9groc0Nyy7SOROy@momjian.us>
 <20230202062838.GA1832088@rfd.leadboat.com>
 <1477791.1675320029@sss.pgh.pa.us>
 <764a8f96-58c3-361d-428f-7ef827d62023@enterprisedb.com>
 <20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 06 Feb 2023 13:21:57 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2828974.1675719367.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 06 Feb 2023 16:36:07 -0500
Message-ID: <2828975.1675719367@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2828975.1675719367%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-02-06 18:17:02 +0100, Peter Eisentraut wrote:
>> First, as a matter of principle, it would introduce another level of
>> gatekeeping power.  Right now, the committers are as a group in charge =
of
>> what gets into the tree.  Adding commit hooks that are installed
>> somewhere(?) by someone(?) and can only be seen by some(?) would upset =
that.
>> If we were using something like github or gitlab (not suggesting that, =
but
>> for illustration), then you could put this kind of thing under .github/=
 or
>> similar and then it would be under the same control as the source code
>> itself.

> Well, we did talk about adding a pre-commit hook to the repository, with
> instructions for how to enable it. And I don't see a problem with adding=
 the
> pre-receive we're discussing here to src/tools/something.

Yeah.  I don't think we are seriously considering putting any restrictions
in place on gitmaster --- the idea is to offer better tools to committers
to let them check/fix the indentation of what they are working on.  If
somebody wants to run that as a local pre-commit hook, that's their choice=
.

			regards, tom lane