Message-ID: <2835e53a-23d6-4999-bca0-0cb27c848319@iki.fi>
Date: Tue, 14 Apr 2026 12:22:27 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Reduce build times of pg_trgm GIN indexes
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 David Geier <geidav.pg@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <66620ec7-0f81-4813-9cf1-b901a56efcc3@gmail.com>
 <CAEze2WiUL9idZBbuUN+MuWqr6DcPr_-C91E9MTx=H62Xx5fHaQ@mail.gmail.com>
 <ef8782c9-68b7-4915-9f79-497765a8e205@gmail.com>
 <a90ebbbd-0d77-49c7-b222-3dbffa4e3b14@gmail.com>
 <2a76b5ef-4b12-4023-93a1-eed6e64968f3@gmail.com>
 <6439c655-e281-409d-b884-6586750d5820@iki.fi>
 <adeNWH5pDawDvvR2@ip-10-97-1-34.eu-west-3.compute.internal>
 <2a2f9cb0-f00d-413c-8517-4a3ad220d104@eisentraut.org>
 <adzNqZdHrWHYCinj@ip-10-97-1-34.eu-west-3.compute.internal>
 <7e6e33a8-9177-45d4-b830-992c1fb5e992@gmail.com>
 <ad0kyPmgh17YqeBn@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <ad0kyPmgh17YqeBn@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2835e53a-23d6-4999-bca0-0cb27c848319%40iki.fi>
Precedence: bulk

On 13/04/2026 20:15, Bertrand Drouvot wrote:
> On Mon, Apr 13, 2026 at 05:03:11PM +0200, David Geier wrote:
>> On 13.04.2026 13:04, Bertrand Drouvot wrote:
>>> On Mon, Apr 13, 2026 at 11:41:02AM +0200, Peter Eisentraut wrote:
>>>> On 09.04.26 13:28, Bertrand Drouvot wrote:
>>>>>
>>>>> This commit makes use of StaticAssertStmt() that has been deprecated in
>>>>> d50c86e74375. The attached, fixes it.
>>
>> I cannot find a comment close to StaticAssertStmt() that says it got
>> deprecated.
> 
> The comment on top of it's definition is:
> 
> "
> /*
>   * StaticAssertStmt() was previously used to make static assertions work as a
>   * statement, but its use is now deprecated.
>   */
> "
> 
>> Is the goal to completely get rid of StaticAssertStmt()?
> 
> According to its comment, I'd say so.
> 
>>> Yeah that looks better to not lose the connection with palloc0_array() here.
>>> Done that way in the attached and adding new braces to avoid warning from
>>> -Wdeclaration-after-statement.
>>
>> Looks good to me.
> 
> Thanks for looking at it!

Committed this StaticAssertStmt/Decl() fix, thanks

- Heikki