Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pDYES-0002RD-8P
	for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Jan 2023 21:57:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pDYER-0006GV-2h
	for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Jan 2023 21:57:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pDYEQ-0006GM-QD
	for pgsql-hackers@lists.postgresql.org; Thu, 05 Jan 2023 21:57:02 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pDYEO-0004Re-2T
	for pgsql-hackers@lists.postgresql.org; Thu, 05 Jan 2023 21:57:01 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 305LutU72837328;
	Thu, 5 Jan 2023 16:56:55 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
cc: James Finnerty <jfinnert@amazon.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
In-reply-to: <3e8cca01-f102-d4b9-abe9-ed7b5e938323@enterprisedb.com>
References: <151e835f-55d6-ddbc-b5b4-07ee606aba44@enterprisedb.com>
 <03182011-10a4-97b4-7c70-d99aa1c11eed@enterprisedb.com>
 <167112207543.1120.12195641719862911275.pgcf@coridan.postgresql.org>
 <3377008.1671122816@sss.pgh.pa.us>
 <cd3f2fda-d4cc-4371-210f-fc339d53b885@enterprisedb.com>
 <6da357b0-fdd3-095d-a06c-87666f4a5a8c@enterprisedb.com>
 <951485.1672461744@sss.pgh.pa.us>
 <233ee0b3-4da0-3370-cd0b-1b8528851ddd@enterprisedb.com>
 <1040922.1672507431@sss.pgh.pa.us>
 <d13d28b9-30d0-27e8-d58e-d3e0c76b3bda@enterprisedb.com>
 <3d719e62-64d2-5184-eebf-6128bcb398e2@enterprisedb.com>
 <2813656.1672952711@sss.pgh.pa.us>
 <3e8cca01-f102-d4b9-abe9-ed7b5e938323@enterprisedb.com>
Comments: In-reply-to Tomas Vondra <tomas.vondra@enterprisedb.com>
	message dated "Thu, 05 Jan 2023 22:47:23 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2837326.1672955815.1@sss.pgh.pa.us>
Date: Thu, 05 Jan 2023 16:56:55 -0500
Message-ID: <2837327.1672955815@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2837327.1672955815%40sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> There are no callers outside postgresAcquireSampleRowsFunc, so what
> about renaming them like this?

>   deparseAnalyzeTuplesSql
>     -> deparseAnalyzeInfoSql

>   postgresCountTuplesForForeignTable
>     -> postgresGetAnalyzeInfoForForeignTable

WFM.

			regards, tom lane