From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: David Rowley <dgrowleyml@gmail.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Paul Ramsey <pramsey@cleverelephant.ca>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Pg18 Recursive Crash
In-reply-to: <CAMbWs48mAZZKW_pHoVZsFfHr_69G=3Vm934p227XpdxNaM0arQ@mail.gmail.com>
References: <99F064C1-B3EB-4BE7-97D2-D2A0AA487A71@cleverelephant.ca> <Z2BtL7ZXEjKkHtNX@nathan> <CAApHDvo11HBcb624eTAkXMBkN3=fji_DP+BqNYGYfNNo8nOxaQ@mail.gmail.com> <2493001.1734473089@sss.pgh.pa.us> <CAMbWs4-8U9q2LAtf8+ghV11zeUReA3AmrYkxzBEv0vKnDxwkKA@mail.gmail.com> <CAApHDvpki1oHgMKw+beUhkPMAafznUQAyVAyqyz7918RMeAt2A@mail.gmail.com> <CAMbWs48mAZZKW_pHoVZsFfHr_69G=3Vm934p227XpdxNaM0arQ@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Thu, 19 Dec 2024 09:11:39 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2838704.1734567760.1@sss.pgh.pa.us>
Date: Wed, 18 Dec 2024 19:22:40 -0500
Message-ID: <2838705.1734567760@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2838705.1734567760%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> I see.  I didn't notice any real issues with that; I was just flagged
> by the XXX comment there, which raises the question of whether it's
> worth working harder to determine the inputOps.

I was intending to add some code to my nodeSetop patch to see if
both input plan nodes use the same fixed slot type, and if so
pass that rather than NULL to BuildTupleHashTableExt.  Perhaps
nodeRecursiveunion could do the same thing (in which case we
probably ought to abstract that out to a subroutine).

			regards, tom lane