From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        Dipesh Pandit <dipesh.pandit@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Jeevan Ladhe <jeevanladhe.os@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Shinoda,
    Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
        Abhijit Menon-Sen <ams@toroid.org>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
        Mark Dilger <mark.dilger@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
In-reply-to: 
 <CA+TgmobU2eO0dOEDNREj0ZNU113kkhv+Phixx8tJ9+2CKOJWYA@mail.gmail.com>
References: <20220321131833.GB28503@telsasoft.com>
 <CA+TgmoZz-F1pA1Vv=-6FOPWuS1eFi2ifNyySV4u6pW0+FBeG-g@mail.gmail.com>
 <20220321182256.GC28503@telsasoft.com>
 <CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com>
 <871qyvrvvm.fsf@wibble.ilmari.org>
 <CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com>
 <384291.1648403267@sss.pgh.pa.us>
 <CA+TgmoZ1DbW_nKeVteVvYt0WvZDhm77_qdb-TErjctW+h5_3Jg@mail.gmail.com>
 <20220328205329.GT28503@telsasoft.com>
 <CA+TgmoYw=UFomz2f8Uq0LtUmvcReRFqKb19YwO2O0Wv0Azz_ng@mail.gmail.com>
 <20220329000727.GV28503@telsasoft.com> <1054320.1648512714@sss.pgh.pa.us>
 <CA+Tgmob-ojwztsfn7uV87q4M8dXOtUgiTcH5=Tpu7UqobFK+8A@mail.gmail.com>
 <CA+TgmobU2eO0dOEDNREj0ZNU113kkhv+Phixx8tJ9+2CKOJWYA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 30 Mar 2022 16:00:39 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <284746.1648671287.1@sss.pgh.pa.us>
Date: Wed, 30 Mar 2022 16:14:47 -0400
Message-ID: <284747.1648671287@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/284747.1648671287%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
>> Maybe if I just put that last sentence into the comment it's clear enough?

> Done that way, since I thought it was better to fix the bug than wait
> for more feedback on the wording. We can still adjust the wording, or
> the coding, if it's not clear enough.

FWIW, I thought that explanation was fine, but I was deferring to
Justin who was the one who thought things were unclear.

			regards, tom lane