Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkY3g-0002pV-Nn for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jan 2019 17:35:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gkY3e-0003pv-I6 for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jan 2019 17:35:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkY3e-0003po-7t for pgsql-hackers@lists.postgresql.org; Fri, 18 Jan 2019 17:35:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkY3b-00033O-OI for pgsql-hackers@postgresql.org; Fri, 18 Jan 2019 17:35:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0IHZnEt028496; Fri, 18 Jan 2019 12:35:49 -0500 From: Tom Lane To: =?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= cc: PostgreSQL mailing lists Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character In-reply-to: References: Comments: In-reply-to =?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= message dated "Fri, 18 Jan 2019 18:15:46 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28493.1547832949.1@sss.pgh.pa.us> Date: Fri, 18 Jan 2019 12:35:49 -0500 Message-ID: <28495.1547832949@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk =?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= writes: > As mentioned in the subject, if the $PATH where you are building postgres > contains a perl's special character [1], for example a `+`, pgbench's tap > tests will fail. Fun. But is that really the only place that fails? > I'm attaching a patch to fix this by using quotemeta [3]. This does not look right to me: glob has a different set of special characters than regexes, no? regards, tom lane