From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Bossart, Nathan" <bossartn@amazon.com>
cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improving psql's \password command
In-reply-to: <E4840C66-2FD5-4A0B-8CC9-A09F8B9126B7@amazon.com>
References: <747443.1635536754@sss.pgh.pa.us>
 <C2787D93-6871-4D93-9CF3-CD7BB489F47F@amazon.com>
 <765509.1635552418@sss.pgh.pa.us>
 <7BAC8A28-148B-4B03-A345-D68071388300@amazon.com>
 <1553329.1636647111@sss.pgh.pa.us>
 <E0C46CDF-46B2-4388-B53B-96EB2CA0F71E@amazon.com>
 <1847699.1636747076@sss.pgh.pa.us>
 <AEA1BA57-BD21-4237-9859-1C04FE38602B@amazon.com>
 <2141902.1636999964@sss.pgh.pa.us>
 <5EDA38EF-C411-4C7D-A9BC-10B1D4584E5E@amazon.com>
 <2152988.1637010233@sss.pgh.pa.us>
 <E4840C66-2FD5-4A0B-8CC9-A09F8B9126B7@amazon.com>
Comments: In-reply-to "Bossart, Nathan" <bossartn@amazon.com>
	message dated "Mon, 15 Nov 2021 21:52:42 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2850851.1637194468.1@sss.pgh.pa.us>
Date: Wed, 17 Nov 2021 19:14:28 -0500
Message-ID: <2850852.1637194468@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2850852.1637194468%40sss.pgh.pa.us>
Precedence: bulk

"Bossart, Nathan" <bossartn@amazon.com> writes:
> You are right.  I'm not sure what I was thinking.  Attached a v3
> with that part removed.

Pushed with a little further tweaking --- mostly, I felt that
explicitly referring to SIGINT in the API names was too
implementation-specific, so I renamed things.

As you mentioned, there are several other simple_prompt() calls
that could usefully be improved.  (I think the one in startup.c
may be OK because we've not set up the SIGINT handler yet,
though.)  I wondered whether it's worth refactoring some more
to have just one function that sets up the context mechanism.

I was also of two minds about whether to add a context option
to pg_get_line_buf().  I stuck with your choice not to, but
it does look a bit inconsistent.

			regards, tom lane