Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gryDH-00040P-A8 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Feb 2019 04:56:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gryDG-0005Ys-17 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Feb 2019 04:56:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gryDF-0005Wq-N5 for pgsql-hackers@lists.postgresql.org; Fri, 08 Feb 2019 04:56:29 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gryDD-00062U-1Y for pgsql-hackers@lists.postgresql.org; Fri, 08 Feb 2019 04:56:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x184uIsL028537; Thu, 7 Feb 2019 23:56:18 -0500 From: Tom Lane To: Noah Misch cc: Andres Freund , pgsql-hackers@lists.postgresql.org, Alvaro Herrera , David Fetter , Andrew Gierth , pgsql-hackers@postgresql.org, daniel@yesql.se, michael@paquier.xyz Subject: Re: Synchronize with imath upstream In-reply-to: <20190208043844.GA562856@rfd.leadboat.com> References: <20190205234750.GA2774@alvherre.pgsql> <23413.1549466124@sss.pgh.pa.us> <20190207055011.GB392703@rfd.leadboat.com> <19483.1549552325@sss.pgh.pa.us> <20190208043844.GA562856@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Thu, 07 Feb 2019 20:38:44 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28535.1549601777.1@sss.pgh.pa.us> Date: Thu, 07 Feb 2019 23:56:18 -0500 Message-ID: <28536.1549601778@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Noah Misch writes: > On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote: >> I have no particular opinion on whether pgindent should be part of the >> mix for imath, but I do strongly recommend setting up and documenting a >> reproducible import process, as I did for src/timezone. > Good idea. I've modified the imath.c header comment to take the form of an > import process; see attached imath1.29-pgedits-v2.patch. Maybe easier to keep the instructions in a separate README file? (I don't see a need to put a PG copyright in this file, when the mods from upstream are this small.) Looks good otherwise. regards, tom lane