From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Benoit =?iso-8859-1?Q?Lobr=E9au?= <benoit.lobreau@gmail.com>,
        Guillaume Lelarge <guillaume@lelarge.info>,
        PostgreSQL Developers <pgsql-hackers@postgresql.org>,
        "Dr. Michael Meskes" <michael.meskes@credativ.com>
Subject: Re: Probable memory leak with ECPG and AIX
In-reply-to: <20220101074055.GA54621@rfd.leadboat.com>
References: 
 <CAECtzeWMVW=b8=DJje_4F=OG9BeYLh-phLcCxZ-FBpii+O=SBQ@mail.gmail.com>
 <20211212073411.GA2218865@rfd.leadboat.com>
 <CAPE8EZ4ca2s5tDVHZzQ=iGh+rD8VX5r4Gk8zTTEeh9VaDOMnuQ@mail.gmail.com>
 <CAPE8EZ42eWAemjj58DO0WArCMDG2VYWut38aAGo9V8QH8ETqrg@mail.gmail.com>
 <20220101074055.GA54621@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Fri, 31 Dec 2021 23:40:55 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2865638.1641054902.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 01 Jan 2022 11:35:02 -0500
Message-ID: <2865639.1641054902@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2865639.1641054902%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> I get the same results.  The leak arises because AIX freelocale() doesn'=
t free
> all memory allocated in newlocale().  The following program uses trivial
> memory on GNU/Linux, but it leaks like you're seeing on AIX:

Bleah.

> If you have access to file an AIX bug, I recommend doing so.  If we want
> PostgreSQL to work around this, one idea is to have ECPG do this newloca=
le()
> less often.  For example, do it once per process or once per connection
> instead of once per ecpg_do_prologue().

It's worse than that: see also ECPGget_desc().  Seems like a case
could be made for doing something about this just on the basis
of cycles expended, never mind freelocale() bugs.

			regards, tom lane