Received: from sss.sss.pgh.pa.us (sss.pgh.pa.us [206.210.65.6]) by hub.org (8.9.1/8.9.1) with ESMTP id OAA22003 for ; Wed, 28 Oct 1998 14:18:30 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.sss.pgh.pa.us (8.9.1/8.9.1) with ESMTP id OAA28709; Wed, 28 Oct 1998 14:16:43 -0500 (EST) To: Bruce Momjian cc: hackers@postgreSQL.org Subject: Re: [HACKERS] Open 6.4 items In-reply-to: Your message of Wed, 28 Oct 1998 11:18:50 -0500 (EST) <199810281618.LAA17561@candle.pha.pa.us> Date: Wed, 28 Oct 1998 14:16:42 -0500 Message-ID: <28707.909602202@sss.pgh.pa.us> From: Tom Lane Bruce Momjian writes: > But we might as well fix it now, because we can't ask for initdb after > the final release. > Can someone check that that fix does not affect the regression test > results? I doubt we do lseg not-equal tests in the regression suite. > You will have to do an initdb to see the change. I just rebuilt and initdb'd. Regression test state is the same as before, except that the new inet test fails: *** expected/inet.out Tue Oct 27 14:34:02 1998 --- results/inet.out Wed Oct 28 14:02:45 1998 *************** *** 53,66 **** i as inet, network(i) as "network(inet)" FROM INET_TBL; eight|cidr |network(cidr)|inet |network(inet) -----+------------+-------------+----------------+------------- ! |192.168.1/24| 0.1.168.192|192.168.1.226/24| 0.1.168.192 ! |192.168.1/24| 0.1.168.192|192.168.1.226 |226.1.168.192 ! |10/8 | 0.0.0.10|10.1.2.3/8 | 0.0.0.10 ! |10.0.0.0/32 | 0.0.0.10|10.1.2.3/8 | 0.0.0.10 ! |10.1.2.3/32 | 3.2.1.10|10.1.2.3 | 3.2.1.10 ! |10.1.2/24 | 0.2.1.10|10.1.2.3/24 | 0.2.1.10 ! |10.1/16 | 0.0.1.10|10.1.2.3/16 | 0.0.1.10 ! |10/8 | 0.0.0.10|10.1.2.3/8 | 0.0.0.10 (8 rows) QUERY: SELECT '' as eight, c as cidr, masklen(c) as "masklen(cidr)", --- 53,66 ---- i as inet, network(i) as "network(inet)" FROM INET_TBL; eight|cidr |network(cidr)|inet |network(inet) -----+------------+-------------+----------------+------------- ! |192.168.1/24| 192.168.1.0|192.168.1.226/24| 192.168.1.0 ! |192.168.1/24| 192.168.1.0|192.168.1.226 |192.168.1.226 ! |10/8 | 10.0.0.0|10.1.2.3/8 | 10.0.0.0 ! |10.0.0.0/32 | 10.0.0.0|10.1.2.3/8 | 10.0.0.0 ! |10.1.2.3/32 | 10.1.2.3|10.1.2.3 | 10.1.2.3 ! |10.1.2/24 | 10.1.2.0|10.1.2.3/24 | 10.1.2.0 ! |10.1/16 | 10.1.0.0|10.1.2.3/16 | 10.1.0.0 ! |10/8 | 10.0.0.0|10.1.2.3/8 | 10.0.0.0 (8 rows) QUERY: SELECT '' as eight, c as cidr, masklen(c) as "masklen(cidr)", ---------------------- Offhand I would say that it's the "expected" file that is broken. Shouldn't those octets be coming out in the other order? regards, tom lane