From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        Peter Eisentraut <peter@eisentraut.org>,
        Zhang Mingli <zmlpostgres@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: =?UTF-8?Q?Re:_[BUG=3F]_macOS_(Intel)_build_warnings:_"ranlib:_fil?=
         =?UTF-8?Q?e_=E2=80=A6_has_no_symbols"_for_aarch64_objects?=
In-reply-to: 
 <CANWCAZYFAP_fP0RSnor9Aa03aYAvQaM=+8oNeZSV432RNNynkQ@mail.gmail.com>
References: <b3e0930c-e86c-4a6e-8059-281424ca6d69@Spark>
 <229aaaf3-f529-44ed-8e50-00cb6909af21@Spark>
 <4df5af1a-8528-4f9f-9daf-ec069bd66f69@eisentraut.org>
 <1453046.1770218933@sss.pgh.pa.us> <aYN5vmHb89m3sfgs@nathan>
 <1472307.1770229663@sss.pgh.pa.us> <aYOTFLqyvvPUQLN8@nathan>
 <ae7BvFTamKBDF1ga@nathan> <2446899.1777256313@sss.pgh.pa.us>
 <ae7KiQcfDaavu5cD@nathan> <ae-8WBrqoTWYCTCG@nathan>
 <CANWCAZYFAP_fP0RSnor9Aa03aYAvQaM=+8oNeZSV432RNNynkQ@mail.gmail.com>
Comments: In-reply-to John Naylor <johncnaylorls@gmail.com>
	message dated "Tue, 28 Apr 2026 13:18:22 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2871417.1777382981.1@sss.pgh.pa.us>
Date: Tue, 28 Apr 2026 09:29:41 -0400
Message-ID: <2871418.1777382981@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2871418.1777382981%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <johncnaylorls@gmail.com> writes:
> It'd be a bit unfortunate for those symbols to bleed out into the
> build system, so it seems best to minimize the need for that and do as
> much as possible with just architecture. src/port/meson.build could do
> instead

> if host_cpu == 'x86' or host_cpu == 'x86_64'
>   pgport_sources += files(
>   'pg_cpu_x86.c',
>   ...etc

This level of refinement is about what I was imagining for the
build systems.  Otherwise, if we add any more platform sub-categories
to those files, we'll have to complicate the build systems to match.

I'm not sure if we need to care about suppressing these warnings to
a greater degree than that.  My impression is that it won't be an
issue for macOS because of the uniformity of the underlying hardware.

If we do care, a low-tech solution could be to have a dummy symbol
declared in each file, along the lines of

#if HAVE_X86_64_POPCNTQ
// code for popcntq case
#elif HAVE_FROBNITZ
// code for frobnitz case
...
#else
/* prevent linker complaints about empty module */
extern int pg_cpu_x86_dummy_variable;
int	pg_cpu_x86_dummy_variable = 0;
#endif

Actually then we'd not need to change the build systems either...

			regards, tom lane