Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hyHal-0001mo-Le for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2019 15:23:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hyHak-0001Xj-Hy for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2019 15:23:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hyHak-0001Xc-97 for pgsql-hackers@lists.postgresql.org; Thu, 15 Aug 2019 15:23:06 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hyHab-0004BT-Kk for pgsql-hackers@postgresql.org; Thu, 15 Aug 2019 15:23:05 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x7FFMrRx028724; Thu, 15 Aug 2019 11:22:53 -0400 From: Tom Lane To: Stephen Frost cc: Ian Barwick , Robert Haas , Tomas Vondra , Amit Kapila , "pgsql-hackers@postgresql.org" Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions In-reply-to: <20190814211520.GK16436@tamriel.snowman.net> References: <30823.1565030571@sss.pgh.pa.us> <32103.1565032053@sss.pgh.pa.us> <20190806005225.GM29202@tamriel.snowman.net> <6cba0dff-485b-6781-d659-0a376b966c89@2ndquadrant.com> <20190806021616.GP29202@tamriel.snowman.net> <54620b18-60b7-4b9b-7d1d-90a6464ab333@2ndquadrant.com> <5879.1565121423@sss.pgh.pa.us> <20190806214355.GA29202@tamriel.snowman.net> <29770.1565810142@sss.pgh.pa.us> <20190814211520.GK16436@tamriel.snowman.net> Comments: In-reply-to Stephen Frost message dated "Wed, 14 Aug 2019 17:15:20 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28722.1565882573.1@sss.pgh.pa.us> Date: Thu, 15 Aug 2019 11:22:53 -0400 Message-ID: <28723.1565882573@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Stephen Frost writes: > * Tom Lane (tgl@sss.pgh.pa.us) wrote: >> In hopes of moving this along, I've pushed Ian's last code change, >> as there seems to be no real argument about that anymore. >> >> As for the doc changes, how about the attached revision of what >> I wrote previously? It gives some passing mention to what ALTER >> SYSTEM will do, without belaboring it or going into things that >> are really implementation details. > It's certainly better than what we have now. Hearing no other comments, I've pushed that and marked this issue closed. regards, tom lane