Message-ID: <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
Date: Fri, 15 Jul 2022 14:01:53 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] Log details for client certificate failures
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <61aa4b6c-9de2-d61b-821a-a34ab1e515e2@enterprisedb.com>
 <CAAWbhmgtVs0VciBwL4KbhQnLfTQKqwJjUUCxzA3SFECPn=ntTA@mail.gmail.com>
 <2ef20161-e99d-a6ea-a36d-577843a2daae@enterprisedb.com>
 <CAAWbhmiQVSAc_rOdW8q9R3GJehxkmaW5-CMbYLgrCjhotSs8Bg@mail.gmail.com>
 <49b48719-d6cf-9e03-fab3-e4505cf9d585@enterprisedb.com>
 <CAAWbhmhbM5zwjjVsYkhTOFrV308iFbsGceWiseSbFPQeq24Fww@mail.gmail.com>
 <059e67f5-3769-24c8-f460-4e5d87af529a@enterprisedb.com>
 <0167a8c5-1754-9121-b994-0719a6493a21@timescale.com>
 <20220715191156.jecddreykoakdljm@awork3.anarazel.de>
 <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>
 <20220715203500.vanqxt23bmufjais@awork3.anarazel.de>
From: Jacob Champion <jchampion@timescale.com>
In-Reply-To: <20220715203500.vanqxt23bmufjais@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2878aee8-a4a6-8078-9740-efe90fcf8328%40timescale.com>
Precedence: bulk

On 7/15/22 13:35, Andres Freund wrote:
>> (And do we want to fix it now, regardless?)
> 
> Yes.

Cool. I can get on board with that.

>> What guarantees are we supposed to be making for log encoding?
> 
> I don't know, but I don't think not caring at all is a good
> option. Particularly for unauthenticated data I'd say that escaping everything
> but printable ascii chars is a sensible approach.

It'll also be painful for anyone whose infrastructure isn't in a Latin
character set... Maybe that's worth the tradeoff for a v1.

Is there an acceptable approach that could centralize it, so we fix it
once and are done? E.g. a log_encoding GUC and either conversion or
escaping in send_message_to_server_log()?

--Jacob