public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Anton A. Melnikov <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: 003_check_guc.pl crashes if some extensions were loaded.
Date: Wed, 01 Nov 2023 19:29:51 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Michael Paquier <[email protected]> writes:
> On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote:
>> "SELECT name
>> FROM pg_settings
>> WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
>> - name <> 'config_file'
>> + name <> 'config_file' AND name NOT LIKE '%.%'
>> ORDER BY 1");
> Wouldn't it be better to add a qual as of "category <> 'Customized
> Options'"?
+1, seems like a cleaner answer.
> That's something arbitrarily assigned for all custom GUCs
> and we are sure that none of them will exist in
> postgresql.conf.sample. There's also no guarantee that out-of-core
> custom GUCs will include a dot in their name (even if I know that
> maintainers close to the community adopt this convention and are
> rather careful about that).
Actually we do force that, see valid_custom_variable_name().
But I think your idea is better.
regards, tom lane
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: 003_check_guc.pl crashes if some extensions were loaded.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox