Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fvkzy-0002Fg-4S
	for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 15:06:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fvkzw-0002iN-FV
	for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 15:06:08 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fvkzw-0002iF-4Y
	for pgsql-hackers@lists.postgresql.org; Fri, 31 Aug 2018 15:06:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fvkzp-0004tR-Tc
	for pgsql-hackers@postgresql.org; Fri, 31 Aug 2018 15:06:06 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w7VF5vun028860;
	Fri, 31 Aug 2018 11:05:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Andres Freund <andres@anarazel.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: remove ancient pre-dlopen dynloader code
In-reply-to: <e11a49cb-570a-60b7-707d-7084c8de0e61@2ndquadrant.com>
References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com>
 <20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de>
 <26726.1533823423@sss.pgh.pa.us>
 <20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
 <8022.1534425734@sss.pgh.pa.us>
 <20180816135928.qer5o7uxyaeolzet@alap3.anarazel.de>
 <10102.1534428424@sss.pgh.pa.us>
 <20180816141005.nkw5nwkmoip57ui6@alap3.anarazel.de>
 <e11a49cb-570a-60b7-707d-7084c8de0e61@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 31 Aug 2018 10:52:18 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28858.1535727957.1@sss.pgh.pa.us>
Date: Fri, 31 Aug 2018 11:05:57 -0400
Message-ID: <28859.1535727957@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> How about this: We only have two nonstandard dlopen() implementations
> left: Windows and (old) HP-UX.  We move those into src/port/dlopen.c and
> treat it like a regular libpgport member.  That gets rid of all those
> duplicative empty per-platform files.

+1.  I eyeballed the patch quickly and it looks sane, but I didn't
try to test it.  Being a lazy person, I don't want to test it manually,
but I'll be happy to queue up a gaur run as soon as you push it
(and if by some chance that shows a problem, I'll fix it).

			regards, tom lane