From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: suppressing useless wakeups in logical/worker.c
In-reply-to: 
 <CA+hUKGLpH=y4=Zx+=oLE8WvLqLHWNC-PEDARrrt=x=J_REL9Fg@mail.gmail.com>
References: <20221202195503.GD2277157@nathanxps13>
 <TYAPR01MB58669549D0137CC76A9BB6A0F5189@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <20221205173523.GA2714833@nathanxps13> <20230109174217.GA1112698@nathanxps13>
 <2557815.1674603908@sss.pgh.pa.us> <20230125235004.GA1327755@nathanxps13>
 <CA+hUKGJ=oFEX=TjeSCnGmqr_KseGLJxy=RnJMwRqPrX7N-Q2sg@mail.gmail.com>
 <20230126003319.GA1507251@nathanxps13> <2878152.1674700077@sss.pgh.pa.us>
 <CA+hUKGLpH=y4=Zx+=oLE8WvLqLHWNC-PEDARrrt=x=J_REL9Fg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 26 Jan 2023 16:57:23 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2888101.1674705840.1@sss.pgh.pa.us>
Date: Wed, 25 Jan 2023 23:04:00 -0500
Message-ID: <2888102.1674705840@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2888102.1674705840%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Jan 26, 2023 at 3:28 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It'd probably be reasonable to file down that sharp edge by instead
>> specifying that TimestampDifferenceMilliseconds will clamp overflowing
>> differences to LONG_MAX.  Maybe there should be a clamp on the underflow
>> side too ... but should it be to LONG_MIN or to zero?

> That got me curious... Why did WaitLatch() use long in the first
> place?

Good question.  It's not a great choice, because of the inherent
platform specificity.  OTOH, I'm not sure it's worth the pain
to change now.

			regards, tom lane