Feedback-ID: i131946ab:Fastmail
Message-ID: <28de92b5-a514-fe1b-1637-ba228aa2cccf@enterprisedb.com>
Date: Wed, 5 Oct 2022 08:40:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [RFC] building postgres with meson - v13
Content-Language: en-US
To: samay sharma <smilingsamay@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 Nathan Bossart <nathandbossart@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>, Nazir Bilal Yavuz
 <byavuz81@gmail.com>, pgsql-hackers@postgresql.org
References: <d861493c-ed20-c251-7a89-7924f5197341@enterprisedb.com>
 <20220920021630.vufrgcjmidimcarq@awork3.anarazel.de>
 <20220921164630.wrklkjmifjqjtlwc@awork3.anarazel.de>
 <20220922055704.fngsvviugsnivebs@awork3.anarazel.de>
 <2b9a02ec-22e6-24df-18ec-b60e3af12995@dunslane.net>
 <20220922150550.pscsjv4nwnslupeg@awork3.anarazel.de>
 <20220922200533.GA697326@nathanxps13>
 <20220922202809.4touie37lfafyabw@awork3.anarazel.de>
 <20220922223729.GA721620@nathanxps13> <2298281.1664041949@sss.pgh.pa.us>
 <20220924180955.2hevwoniwsj2q2tm@awork3.anarazel.de>
 <c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com>
 <CAJxrbyxSjV0G7hCGKc=Ym2q=cy3g3Gd1tukfOXZncQqetw_cRA@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAJxrbyxSjV0G7hCGKc=Ym2q=cy3g3Gd1tukfOXZncQqetw_cRA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/28de92b5-a514-fe1b-1637-ba228aa2cccf%40enterprisedb.com>
Precedence: bulk

On 03.10.22 09:39, samay sharma wrote:
>     9f5be26c1215 meson: Add docs for building with meson
> 
>     I do like the overall layout of this.
> 
>     The "Supported Platforms" section should be moved back to near the end
>     of the chapter.  I don't see a reason to move it forward, at least
>     none that is related to the meson issue.
> 
> 
> Agreed that it's unrelated to meson. However, I think it's better to 
> move it in the front as it's generally useful to know if your platform 
> is supported before you start performing the installation steps and get 
> stuck somewhere.

The way it is currently organized is that 17.2 says

"In general, a modern Unix-compatible platform should be able to run 
PostgreSQL. The platforms that had received specific testing at the time 
of release are described in Section 17.6 below."

So basically, it says, don't worry about it, your platform is probably 
supported, but check below if you are interested in the details.

I don't see a reason to turn this around.

> 
> Do you think I should submit that as a separate commit in the same 
> patch-set or just move it out to a completely different patch submission?
> 
> 
>     The changes to the "Getting the Source" section are also not
>     appropriate for this patch.
> 
> 
> Given that many developers are now using Git for downloading the source 
> code, I think it makes sense to be in the Getting the source section. 
> Also, meson today doesn't cleanly build via the tarballs. Hence, I added 
> it to the section (and patchset).

Section 17.3 already contains a link to section I.1 about using Git.

> Do you think I should move this to a different patch?

If you wanted to pursue these changes, then yes, but I think they are 
not clear improvements, as mentioned above.

I suggest focusing on getting the actual meson documentation finished 
and then considering polishing the overall flow if desired.