Feedback-ID: i131946ab:Fastmail
Message-ID: <28e95b5f-9162-de57-c4da-a85b909bb9b0@enterprisedb.com>
Date: Thu, 6 Oct 2022 09:06:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: meson: Add support for building with precompiled headers
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
 Thomas Munro <thomas.munro@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Michael Paquier <michael.paquier@gmail.com>
References: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/28e95b5f-9162-de57-c4da-a85b909bb9b0%40enterprisedb.com>
Precedence: bulk

On 05.10.22 21:08, Andres Freund wrote:
> This is a patch split off from the initial meson thread [1] as it's
> functionally largely independent (as suggested in [2]).
> 
> Using precompiled headers substantially speeds up building for windows, due to
> the vast amount of headers included via windows.h. A cross build from
> linux targetting mingw goes from

These patches look ok to me.  I can't really comment on the Windows 
details, but it sounds all reasonable.

Small issue:

+override CFLAGS += -DFD_SETSIZE=1024

(and similar)

should be CPPFLAGS.