Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rtnfU-00HaLf-Fn for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2024 12:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rtnfT-005cvO-AE for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2024 12:00:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rtnfT-005cvE-0E for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2024 12:00:07 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rtnfQ-001otG-NB for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2024 12:00:05 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2d71765d3e1so52221041fa.0 for ; Mon, 08 Apr 2024 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712577602; x=1713182402; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SDnISx03OH7yfAvM0WzYEbRVe1voSIKjZq8r4kAWzlA=; b=j/id+UMRAP3iOSg/bddwJhmQvdenNg+c0+e9d/lnPRw7iUQWPTJrpoZAIdfyvWtH5b TYp4b/9cvx82NHlCVWOm9wI/vXQkesDdFekJIUAxOBMKaDGWXe4/RQo2p12fg/p+oZRi Fmyn5tqy1lMFooIQdfs5x6VkuBQbkCO73a09EO7kXblFojj86f5XYxdcEmnZgStEweFK hfRwqqwAddVpmmoKdwoC7rJ0GS/qJnPnbhJcu0Jg2s59aJdx3nkAvesWsoqeIiE9Y4V5 cajZ8jl+4kuuvd+y/XwETl5YyHrAiwL2ld9FsDZcH4acPE50+58dg5XnqcwABBR5ZPmO pGQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712577602; x=1713182402; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SDnISx03OH7yfAvM0WzYEbRVe1voSIKjZq8r4kAWzlA=; b=t+aJg0hYZXJYeQJXULFsQjq7ZJAP5OlTVqcjJy7hdglI371iVCOYLoSDc/Bgs0GS9Y lUwWbjgj+srfv9NfI6btK7Mq4zLMIEtQeKrHw7GBDi3OmJ83kJckWHo6kFn3sU7k7pJn oaV0lVFVBnWWmZoEjtG6dXdox4y5moP4Iow9SzregIgg67JFqlQtUlAHOWOqrXm2nh/K 386ciw/OmF8Kw5GPskHs/O85WBiStuQYCMxenMA9U0FC4N2RgMAip8Y24Ty77mI+RwHe dpfB7ynzNq5Hvx/nLt+i/v0Tfvaxat7YZQ/VfglQOjbGwhAWGFTnDYv4sn4i9rkz7150 9KPg== X-Gm-Message-State: AOJu0YylFkcGtEzVOQf5sipvMekpTa3n1wUnMKFBtdObJWtHwrazxCOB Z/LeFvFigbXOVkRJ6UkfPSWda7hFZFyZddypLpcsi6J08FuSu7VQ X-Google-Smtp-Source: AGHT+IGoBg9+TVSjJ2isaW62bepD8G2bhe6VnCcoayS0C7UAJHDi2v2LRZpcw57/XboyZLCwKXZvkQ== X-Received: by 2002:a2e:2e07:0:b0:2d6:d52c:7b24 with SMTP id u7-20020a2e2e07000000b002d6d52c7b24mr6467283lju.24.1712577601894; Mon, 08 Apr 2024 05:00:01 -0700 (PDT) Received: from [1.0.0.7] ([178.155.25.248]) by smtp.gmail.com with ESMTPSA id f22-20020a2ea0d6000000b002d8796ea1c5sm855179ljm.15.2024.04.08.05.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 05:00:01 -0700 (PDT) Message-ID: <28ed1ee0-749d-9838-955e-abff42fc44be@gmail.com> Date: Mon, 8 Apr 2024 15:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands Content-Language: en-US To: Tender Wang , Alexander Korotkov , Dmitry Koval Cc: PostgreSQL Hackers References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org> <171085858750.2046434.12246066729700037354.pgcf@coridan.postgresql.org> <909e16b4-9eda-435c-b033-8294ae4adc05@postgrespro.ru> <3a4b9c1c-3edf-4e29-9629-b4113aefb0f3@postgrespro.ru> From: Alexander Lakhin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Tender Wang, 08.04.2024 13:43, Tender Wang wrote: > Hi all, >   I went through the MERGE/SPLIT partition codes today, thanks for the works.  I found some grammar errors: >  i. in error messages(Users can see this grammar errors, not friendly). > ii. in codes comments > On a quick glance, I saw also: NULL-value partitionde splited temparary And a trailing whitespace at:      the quarter partition back to monthly partitions: warning: 1 line adds whitespace errors. I'm also confused by "administrators" here: https://www.postgresql.org/docs/devel/ddl-partitioning.html (We can find on the same page, for instance: ... whereas table inheritance allows data to be divided in a manner of the user's choosing. It seems to me, that "users" should work for merging partitions as well.) Though the documentation addition requires more than just a quick glance, of course. Best regards, Alexander