From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Michael Paquier <michael@paquier.xyz>,
        Julien Rouhaud <rjuju123@gmail.com>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-reply-to: <alpine.DEB.2.22.394.2104121156200.244363@pseudo>
References: <1ec5ef49-b5c8-4129-e680-fe42f8d0670b@2ndquadrant.com>
 <alpine.DEB.2.22.394.2104062323150.2555247@pseudo>
 <OSZPR01MB631017521EE6887ADC9492E8FD759@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <alpine.DEB.2.22.394.2104071516470.2724014@pseudo>
 <OSZPR01MB6310325023E8B4109BB2AB90FD749@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <20210408163050.fca7dwb37zszbsmm@nol>
 <alpine.DEB.2.22.394.2104081858500.3192110@pseudo>
 <20210408171135.ekhdf5nvqss554q3@nol> <YG+okFpc3JaKN/zB@paquier.xyz>
 <alpine.DEB.2.22.394.2104090828330.3253600@pseudo>
 <YHAxrQPk2E62wQSS@paquier.xyz>
 <alpine.DEB.2.22.394.2104091947240.3439700@pseudo>
 <2671235.1618154047@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104121156200.244363@pseudo>
Comments: In-reply-to Fabien COELHO <coelho@cri.ensmp.fr>
	message dated "Mon, 12 Apr 2021 16:25:33 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2902361.1618244606.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 12 Apr 2021 12:23:26 -0400
Message-ID: <2902362.1618244606@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2902362.1618244606%40sss.pgh.pa.us>
Precedence: bulk

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Between this and the known breakage of control-C, it seems clear
>> to me that this patch was nowhere near ready for prime time.
>> I think shoving it in on the last day before feature freeze was
>> ill-advised, and it ought to be reverted.  We can try again later.

> The patch has been asleep for quite a while, and was resurrected, possib=
ly =

> too late in the process. ISTM that fixing it for 14 is manageable, =

> but this is not my call.

I just observed an additional issue that I assume was introduced by this
patch, which is that psql's response to a server crash has gotten
repetitive:

regression=3D# CREATE VIEW v1(c1) AS (SELECT ('4' COLLATE "C")::INT FROM g=
enerate_series(1, 10));
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
The connection to the server was lost. Attempting reset: Failed.
!?> =


I've never seen that before, and it's not because I don't see
server crashes regularly.

			regards, tom lane