From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: =?utf-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl
 special character
In-reply-to: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
References: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Fri, 18 Jan 2019 16:27:38 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29025.1547841766.1@sss.pgh.pa.us>
Date: Fri, 18 Jan 2019 15:02:46 -0500
Message-ID: <29026.1547841766@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> This does not look right to me: glob has a different set of special
>>> characters than regexes, no?

> Perhaps you can do
>    @quoted = map { quotemeta($_) } @logs;

Actually, playing with it here, it seems that quotemeta() quotes
anything that's a special character for either purpose (in fact,
it looks like it quotes anything that's not alphanumeric).
So the patch as given should work.

			regards, tom lane