From: Tom Lane <tgl@sss.pgh.pa.us>
To: sirisha chamarthi <sirichamarthi22@gmail.com>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        bharath.rupireddyforpostgres@gmail.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
In-reply-to: <CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>
References: <CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com> <CALj2ACUtyW94TF76WEM-2JvMMD1a1PzLuaW5Qd9rrKRgnMAZnw@mail.gmail.com> <20221020.115946.1240575541659272220.horikyota.ntt@gmail.com> <CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>
Comments: In-reply-to sirisha chamarthi <sirichamarthi22@gmail.com>
	message dated "Thu, 20 Oct 2022 09:40:24 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <291748.1674171832.1@sss.pgh.pa.us>
Date: Thu, 19 Jan 2023 18:43:52 -0500
Message-ID: <291749.1674171832@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/291749.1674171832%40sss.pgh.pa.us>
Precedence: bulk

sirisha chamarthi <sirichamarthi22@gmail.com> writes:
> On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:
>> In short, the proposed fix alone seems fine to me. If we want to show
>> further details, I would add a bit as follows.
>> 
>> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on
>> | *   a slot with this LSN cannot continue.  Note that the affected
>> | *   processes have been terminated by checkpointer, too.

> Thanks for your comments! Attached the patch with your suggestions.

Pushed with a bit of additional wordsmithing.  I thought "have been"
was a bit too strong of an assertion considering that this function
does not pay any attention to the actual state of any processes,
so I made it say "should have been".

			regards, tom lane