Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTXxG-0000AF-I5 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Jan 2017 17:53:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cTXxF-0001rY-QA for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Jan 2017 17:53:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cTXvq-0000Ff-Sy for pgsql-hackers@postgresql.org; Tue, 17 Jan 2017 17:52:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cTXvk-0007fw-7A for pgsql-hackers@postgresql.org; Tue, 17 Jan 2017 17:52:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0HHqK6N029208; Tue, 17 Jan 2017 12:52:20 -0500 From: Tom Lane To: Robert Haas cc: Andres Freund , "pgsql-hackers@postgresql.org" Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) In-reply-to: References: <20160912173815.dlew2xsblcso33sw@alap3.anarazel.de> <17324.1473716167@sss.pgh.pa.us> <20160912220705.b77smzorutebnbee@alap3.anarazel.de> <19682.1473719703@sss.pgh.pa.us> <20160912231144.f3nseocp274iq7wg@alap3.anarazel.de> <23413.1473723322@sss.pgh.pa.us> <20160912234630.caueobrrbg5vse5y@alap3.anarazel.de> <557.1473895705@sss.pgh.pa.us> <20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de> <20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de> <20170116083316.2izqrxbvmyalazac@alap3.anarazel.de> <21924.1484593998@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 17 Jan 2017 12:05:04 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29206.1484675540.1@sss.pgh.pa.us> Date: Tue, 17 Jan 2017 12:52:20 -0500 Message-ID: <29207.1484675540@sss.pgh.pa.us> X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Mon, Jan 16, 2017 at 2:13 PM, Tom Lane wrote: >> "Srf" is ugly as can be, and unintelligible. SetResult might be OK. > The operation we're performing here, IIUC, is projection. SetResult > lacks a verb, although Set could be confused with one; someone might > think this is the node that sets a result, whatever that means. > Anyway, I suggest working Project in there somehow. If Project by > itself seems like it's too generic, perhaps ProjectSet or > ProjectSetResult would be suitable. Andres' patch is already using "SetProjectionPath" for the path struct type. Maybe make that "ProjectSetPath", giving rise to a "ProjectSet" plan node? I'm happy to do a global-search-and-replace while I'm reviewing the patch, but let's decide on names PDQ. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers