From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matheus Alcantara <mths.dev@pm.me>
cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add tests for psql tab completion
In-reply-to: <cyYnAHiGk0M96LLOz3UUdsndyxD0LFdzDSJmCT49bKlPkr-p4GassX9_hEzWup_kkFr9n6ETce7BwvVRoxL59iJlkCNk1mPL82W2rXVeGX4=@pm.me>
References: <cyYnAHiGk0M96LLOz3UUdsndyxD0LFdzDSJmCT49bKlPkr-p4GassX9_hEzWup_kkFr9n6ETce7BwvVRoxL59iJlkCNk1mPL82W2rXVeGX4=@pm.me>
Comments: In-reply-to Matheus Alcantara <mths.dev@pm.me>
	message dated "Sat, 12 Feb 2022 20:17:29 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2920742.1644868864.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 14 Feb 2022 15:01:04 -0500
Message-ID: <2920743.1644868864@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2920743.1644868864%40sss.pgh.pa.us>
Precedence: bulk

Matheus Alcantara <mths.dev@pm.me> writes:
> I'm attaching a patch that add some new test cases for tab completion of=
 psql.

What exactly is the motivation for these particular tests?

I believe that most of tab-complete.c is already covered, outside
of the giant if-else chain at the heart of psql_completion().
It's hard to summon interest in trying to cover every branch of
that chain; but if we're to add coverage of just a few more,
which ones and why?  The ones you've chosen to hit in this
patch don't seem especially interesting.

			regards, tom lane