From: Tom Lane <tgl@sss.pgh.pa.us>
To: Arthur Zakirov <zaartur@gmail.com>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers@postgresql.org,
        Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: CREATE TEXT SEARCH DICTIONARY segfaulting on 9.6+
In-reply-to: <3d98671e-f2ea-40ec-d0e7-d5c5cbb16ca3@gmail.com>
References: <20191013012610.2p2fp3zzpoav7jzf@development>
 <3d98671e-f2ea-40ec-d0e7-d5c5cbb16ca3@gmail.com>
Comments: In-reply-to Arthur Zakirov <zaartur@gmail.com>
	message dated "Mon, 28 Oct 2019 11:59:01 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29256.1572727680.1@sss.pgh.pa.us>
Date: Sat, 02 Nov 2019 16:48:00 -0400
Message-ID: <29257.1572727680@sss.pgh.pa.us>
Precedence: bulk

Arthur Zakirov <zaartur@gmail.com> writes:
> On 2019/10/13 10:26, Tomas Vondra wrote:
>> So I think we need some sort of cross-check here. We certainly need to
>> make NISortDictionary() check the affix value is within AffixData
>> bounds, and error out when the index is non-sensical (maybe negative
>> and/or exceeding nAffixData).

> I agree, I attached the patch which do this. I also added couple 
> asserts, tests and fixed condition in getAffixFlagSet():

> -		if (curaffix > 0 && curaffix <= Conf->nAffixData)
> +		if (curaffix > 0 && curaffix < Conf->nAffixData)

Looks reasonable to me, and we need to get something done before
the upcoming releases, so I pushed this.  Perhaps there's more
that could be done later.

			regards, tom lane