Received: from maia.hub.org (maia-5.hub.org [200.46.204.29])
	by mail.postgresql.org (Postfix) with ESMTP id E41B81337B7E
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Sat, 22 Jan 2011 21:34:06 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024)
	with ESMTP id 56683-10
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Sun, 23 Jan 2011 01:34:01 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 745A313364DE
	for <pgsql-hackers@postgresql.org>;
	Sat, 22 Jan 2011 21:33:59 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p0N1XshB029280;
	Sat, 22 Jan 2011 20:33:54 -0500 (EST)
To: Robert Haas <robertmhaas@gmail.com>
cc: Greg Smith <greg@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>,
	Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Subject: Re: auto-sizing wal_buffers 
In-reply-to: <11561.1295742146@sss.pgh.pa.us> 
References: <AANLkTik3mZ3sTfbHQW-1B44NRMkUzRsMnPb8g-HtttVv@mail.gmail.com>
	<AANLkTimQ3+osgAEH4meS97FmLN-4evSTS2W6fctov=jY@mail.gmail.com>
	<AANLkTinhU9EEPGM29S+KH=qK4t-mLhBBNAaLCGQSx-4y@mail.gmail.com>
	<20767.1294964709@sss.pgh.pa.us> <4D314406.3000703@2ndquadrant.com>
	<AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com>
	<4D31D0E4.9000108@2ndquadrant.com>
	<AANLkTikpeVE-XMZL4L4Mi4zUd7S-D1JckO97_wjp8t3M@mail.gmail.com>
	<11561.1295742146@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 22 Jan 2011 19:22:26 -0500"
Date: Sat, 22 Jan 2011 20:33:54 -0500
Message-ID: <29279.1295746434@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9,
	T_RP_MATCHES_RCVD=-0.01
X-Spam-Level: 
X-Archive-Number: 201101/2186
X-Sequence-Number: 180023

I wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Barring screams of agony^W^W^Whelpful suggestions for how to code this
>> more neatly, I'll go ahead and commit this.

> The show_hook sucks, and is unnecessary, as is exposing the format
> function.  Just set the GUC variable to the correct value.

Um: that was probably too brief.  "Just set" means "use SetConfigOption".
As penance, I've committed the corrected patch.

			regards, tom lane