From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: pgsql-committers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
In-reply-to: <CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
References: <E1pkTFl-001hzA-LR@gemulon.postgresql.org> <CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Fri, 07 Apr 2023 15:04:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2929173.1680876023.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 07 Apr 2023 10:00:23 -0400
Message-ID: <2929174.1680876023@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2929174.1680876023%40sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> psql: add an optional execution-count limit to \watch.

> This commit makes tests fail for me.  psql parses 'i' option of
> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
> decimal separator.

Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
TAP tests.  It seems unfortunate that none of the buildfarm has noticed
this.  I guess all the TAP tests are run under C locale?

> The proposed fix is attached.

LGTM, will push in a bit (unless you want to?)

			regards, tom lane