From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Pg Hackers <pgsql-hackers@postgresql.org>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
In-reply-to: <20146.1487348061@sss.pgh.pa.us>
References: 
 <CAEepm=15e9L695yVCO-_OkBVbsPupyXqzYWzzDmj-bdJ6o2+Pw@mail.gmail.com>
 <20146.1487348061@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 17 Feb 2017 11:14:21 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29305.1487352105.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 17 Feb 2017 12:21:45 -0500
Message-ID: <29306.1487352105@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

I wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
>> Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUB=
JECT.

> Hmm ... I thought we had at least one buildfarm member still testing
> --disable-integer-datetimes.  Evidently somebody needs to close that
> gap.

The plot thickens: we *do* have one such critter, mandrill, but for some
reason it's not generating any complaint about this.  Must be a very
lax compiler.

My own compilers don't generate errors either, only warnings.  Maybe
we could catch this sort of thing mechanically with a critter configured
with -Werror as well as --disable-integer-datetimes, but I'm a tad
hesitant to have a buildfarm machine configured with -Werror.  We'd
be raising the stakes quite a bit on keeping the code warning-free
for a specific compiler that might prove to be picky in silly ways.

But if it were a pretty mainstream compiler that hadn't shown much
evidence of wanting to throw useless warnings, maybe that's fine.

Thoughts?

			regards, tom lane


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers