From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Making C function declaration parameter names consistent with
 corresponding definition names
In-reply-to: 
 <CAH2-WzkxuxfhgbToOrx_tz+KObzYQP+2MN6dBQoD-jy8vC8_0Q@mail.gmail.com>
References: 
 <CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com>
 <3913123.1663370391@sss.pgh.pa.us>
 <CAH2-WzmxBXZAE6eyAm1XyPp6X7epCwih5qBupTxQOc6Hqp48fQ@mail.gmail.com>
 <3922750.1663372191@sss.pgh.pa.us>
 <CAH2-Wzk2etJjj8rhKn9MG9hQ2B+5tWuZneCkGyusqraGQaaeBA@mail.gmail.com>
 <3955318.1663377656@sss.pgh.pa.us>
 <CAH2-WzmykEKQzrcxHZNAuUs7GE2pL+jMa=vMZAzoXhrjG6L6XQ@mail.gmail.com>
 <CAH2-WzkxuxfhgbToOrx_tz+KObzYQP+2MN6dBQoD-jy8vC8_0Q@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sat, 17 Sep 2022 11:05:09 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29326.1663439185.1@sss.pgh.pa.us>
Date: Sat, 17 Sep 2022 14:26:25 -0400
Message-ID: <29327.1663439185@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/29327.1663439185%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> Several files from src/timezone and from src/backend/regex make use of
> unnamed parameters in function declarations. It wouldn't be difficult
> to fix everything and call it a day, but I wonder if there are any
> special considerations here. I don't think that Henry Spencer's regex
> code is considered vendored code these days (if it ever was), so that
> seems clear cut. I'm less sure about the timezone code.

Yeah, bringing the regex code into line with our standards is fine.
I don't really see a reason not to do it with the timezone code
either, as long as there aren't too many changes there.  We are
carrying a pretty large number of diffs from upstream already.

(Which reminds me that I need to do another update pass on that
code soon.  Not right now, though.)

			regards, tom lane