Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olHit-00079F-K1 for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Oct 2022 22:39:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1olHis-0004m7-Ci for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Oct 2022 22:39:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olHis-0004ls-3q for pgsql-hackers@lists.postgresql.org; Wed, 19 Oct 2022 22:39:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olHip-0003FG-QM for pgsql-hackers@lists.postgresql.org; Wed, 19 Oct 2022 22:39:37 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 29JMdW1o2933410; Wed, 19 Oct 2022 18:39:32 -0400 From: Tom Lane To: Corey Huinker cc: pgsql-hackers@lists.postgresql.org Subject: Re: ts_locale.c: why no t_isalnum() test? In-reply-to: References: <2548310.1664999615@sss.pgh.pa.us> Comments: In-reply-to Corey Huinker message dated "Wed, 19 Oct 2022 18:12:47 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2933408.1666219172.1@sss.pgh.pa.us> Date: Wed, 19 Oct 2022 18:39:32 -0400 Message-ID: <2933409.1666219172@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Corey Huinker writes: > I see this is already committed, but I'm curious, why do t_isalpha and > t_isdigit have the pair of /* TODO */ comments? This unfinished business > isn't explained anywhere in the file. We really ought to be consulting the locale/collation passed to the SQL-level operator or function that's calling these things, instead of hard-wiring the database default. Passing that down would take a large and boring patch, but somebody ought to tackle it someday. regards, tom lane