MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 02 Nov 2023 12:24:50 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz,
 pgsql-hackers@postgresql.org, bungina@gmail.com,
 pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
In-Reply-To: 
 <CAFh8B=k80mdYeEZf6OMpQSMXa7rj5trwoGBVZv+7Lha900HpvQ@mail.gmail.com>
References: <8b385bb6d5f87e54c1c6333fece0444a@oss.nttdata.com>
 <ZORIVnxs+lXoEAQG@paquier.xyz>
 <CAFh8B=k2DUwruBA3djsMf3b_wfqeN092iqaDcZYJ4PAgnne2KA@mail.gmail.com>
 <20230824.094538.2107929879048686192.horikyota.ntt@gmail.com>
 <bb706f8393c5207812268a5a2e3f98d7@oss.nttdata.com>
 <CAFh8B=m0TuTNyPzOC6zWrVH2iOEnuNyuPSazqTgjVbd=nt3B2Q@mail.gmail.com>
 <CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
 <763cac924055f1669578bea950c667c7@oss.nttdata.com>
 <CAFh8B=k80mdYeEZf6OMpQSMXa7rj5trwoGBVZv+7Lha900HpvQ@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <293cf2c14c149cb333dd30ae39e08e4e@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/293cf2c14c149cb333dd30ae39e08e4e%40oss.nttdata.com>
Precedence: bulk

On 2023-10-31 00:26, Alexander Kukushkin wrote:
> Hi,
> 
> On Wed, 18 Oct 2023 at 08:50, torikoshia <torikoshia@oss.nttdata.com>
> wrote:
> 
>> I have very minor questions on the regression tests mainly regarding
>> the
>> consistency with other tests for pg_rewind:
> 
> Please find attached a new version of the patch. It addresses all your
> comments.

Thanks for updating the patch!

> +extern void preserve_file(char *filepath);

Is this necessary?
This function was defined in older version patch, but no longer seems to 
exist.

+# We use "perl -e 'exit(1)'" as a alternative to "false", because the 
last one
'a' should be 'an'?


-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation