From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Transform for pl/perl
In-reply-to: <d8jlgbq66t9.fsf@dalvik.ping.uio.no>
References: <20180606161453.tvp4ltavlcvejmmz@alvherre.pgsql>
 <e5130c85-23da-5d11-ca74-6a050cc5fa85@2ndquadrant.com>
 <d8jlgbq66t9.fsf@dalvik.ping.uio.no>
Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker?=)
	message dated "Thu, 07 Jun 2018 14:54:10 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2940.1529347229.1@sss.pgh.pa.us>
Date: Mon, 18 Jun 2018 14:40:29 -0400
Message-ID: <2941.1529347229@sss.pgh.pa.us>
Precedence: bulk

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> [ 0001-Fix-excess-enreferencing-in-plperl-jsonb-transform.patch ]

I tested this a bit more thoroughly by dint of applying Data::Dumper
to the Perl values, and found that we were still getting extra references
to sub-objects, for example

INFO:  $VAR1 = {'1' => \{'2' => \['3','4','5']},'2' => '3'};

where what we want is

INFO:  $VAR1 = {'1' => {'2' => ['3','4','5']},'2' => '3'};

That turns out to be because the newRV() call in JsonbValue_to_SV()
is also superfluous, if we've set up refs around HV and AV scalars.

Pushed with that change and the extra testing technology.  I'll go
push the dereferencing patch I proposed shortly, as well.

The remaining unresolved issue in this thread is Ilmari's suggestion
that we should convert integers to Perl IV (or UV?) if they fit, rather
than always convert to NV as now.  I'm inclined to reject that proposal,
though, and not just because we don't have a patch for it.  What's
bothering me about it is that then the behavior would be dependent
on the width of IV in the particular Perl installation.  I think that
is a platform dependency we can do without.

			regards, tom lane