From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
In-reply-to: <37F95EC7-9557-4273-A274-A51D565C6B4A@yesql.se>
References: <31473.1573412838@sss.pgh.pa.us>
 <124042D9-F307-402A-80ED-395C154858BA@yesql.se>
 <4978.1573420358@sss.pgh.pa.us>
 <63DE9A1C-5F59-47AF-90C9-26A7EF9897B3@yesql.se>
 <12987.1573427177@sss.pgh.pa.us> <2798740.1619622555@sss.pgh.pa.us>
 <7062C2A2-BF72-41EC-A058-9A31F8AAC550@yesql.se>
 <2940601.1619642871@sss.pgh.pa.us>
 <37F95EC7-9557-4273-A274-A51D565C6B4A@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 28 Apr 2021 22:58:01 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2942990.1619646255.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 28 Apr 2021 17:44:15 -0400
Message-ID: <2942991.1619646255@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2942991.1619646255%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 28 Apr 2021, at 22:47, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This wording is copied-and-pasted from the other similar tests.  I agre=
e
>> that it's advocating a solution that might be overkill, but if we chang=
e
>> it we should also change the existing messages.  =


> Good point.

>> I don't mind doing that in HEAD; less sure about the back branches, as

> I think it would be helpful for users to try and give slightly more expa=
nded
> advice while (obviously) still always being safe.  I=E2=80=99m happy to =
take a crack at
> that once back unless someone beats me to it.

Seems like s/remove the problem tables/drop the problem columns/
is easy and sufficient.

>> (I think) these are translatable strings.

> If they aren't I think we should try and make them so to as far as we ca=
n
> reduce language barrier problems in such important messages.

Checking, I see they do appear in pg_upgrade's po files.  So I propose
that we change the existing messages in HEAD but not the back branches.

			regards, tom lane