Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1euJN0-0005o4-RK
	for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 14:51:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1euJMz-0003B0-Kd
	for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 14:51:41 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <sk@zsrv.org>)
	id 1euJMz-0003Ap-72
	for pgsql-hackers@lists.postgresql.org; Fri, 09 Mar 2018 14:51:41 +0000
Received: from forward105o.mail.yandex.net ([2a02:6b8:0:1a2d::608])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <sk@zsrv.org>)
	id 1euJMq-0005kQ-R5
	for pgsql-hackers@postgresql.org; Fri, 09 Mar 2018 14:51:39 +0000
Received: from mxback7o.mail.yandex.net (mxback7o.mail.yandex.net
 [IPv6:2a02:6b8:0:1a2d::21])
	by forward105o.mail.yandex.net (Yandex) with ESMTP id 178564440F66;
	Fri,  9 Mar 2018 17:51:28 +0300 (MSK)
Received: from localhost (localhost [::1])
	by mxback7o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id
 t0chj7zPj4-pPwG7eKZ;
	Fri, 09 Mar 2018 17:51:27 +0300
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zsrv.org; s=mail;
 t=1520607087;
	bh=Dsll48SLN0r4mTeMQ+4HXRx9yapUNbhhtyfthiehsQk=;
	h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date;
	b=j20VaCvGzbqegOFRbQNEgMWDeppzf5cBYagozkEst3e/x1gAII5Of6+cnVS47k0o9
	 kIywGQGPwKHm2n7W8eOx7VvjuP5IXyzpYkKXls3EP4sh/woD2+7ZDidGwPCtpNpJwb
	 UaithpKebHhnQFU4Ok1z7SEi/cIhn7rRKktGlR0Y=
Authentication-Results: mxback7o.mail.yandex.net; dkim=pass header.i=@zsrv.org
Received: by web26g.yandex.ru with HTTP;
	Fri, 09 Mar 2018 17:51:25 +0300
From: Sergei Kornilov <sk@zsrv.org>
To: Ildar Musin <i.musin@postgrespro.ru>,
	Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Stephen Frost <sfrost@snowman.net>,
	Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
In-Reply-To: <082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
References: <880511520351578@web5j.yandex.ru>
	 <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
	 <1715451520361128@web26o.yandex.ru> <1142.1520362313@sss.pgh.pa.us>
 <082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
MIME-Version: 1.0
Message-Id: <2947361520607085@web26g.yandex.ru>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Fri, 09 Mar 2018 17:51:25 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Hello all!
Summarizing, how i must update tests?
We want test real skip of verify phase or only result correctness?

I can verify what i do not break alter table by tests in v4 of my patch. But here is no check code path. So my feature may be broken in future without test fail. alter table will be correct regardless this feature.
Or i must test code path too? I understood Tom and will remove INFO ereport from patch anyway. But currently i have no idea how check code path. As mentioned earlier using debug ereport is uncomfortable too. Here is no suitable event trigger to track what exactly happens with table. Adding new one for test purposes seems overkill.

regards, Sergei