From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jakob Egger <jakob@eggerapps.at>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PG vs macOS Mojave
In-reply-to: <DF261D4E-DFB6-4474-9B35-7BBEC93AD959@eggerapps.at>
References: <20840.1537850987@sss.pgh.pa.us>
 <DF261D4E-DFB6-4474-9B35-7BBEC93AD959@eggerapps.at>
Comments: In-reply-to Jakob Egger <jakob@eggerapps.at>
	message dated "Tue, 16 Oct 2018 13:56:49 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29534.1539698523.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 16 Oct 2018 10:02:03 -0400
Message-ID: <29535.1539698523@sss.pgh.pa.us>
Precedence: bulk

Jakob Egger <jakob@eggerapps.at> writes:
> Am 25. Sep. 2018 um 06:49 schrieb Tom Lane <tgl@sss.pgh.pa.us>:
>> It's a bit scary to be adding -isysroot globally.

> This breaks building extensions with a different SDK than the server its=
elf.

Hm, under what circumstances would that be safe or a good idea?

The concerns that strike my mind are mainly around the hazard that
configure's choices could be inappropriate for a build with a
different SDK.  Given that, though, wiring -isysroot into the
configure output doesn't seem all that insane.

It's possible that we could arrange things so that the generated
Makefile.global looks like

PG_SYSROOT =3D /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX=
.platform/Developer/SDKs/MacOSX10.14.sdk =

CPPFLAGS =3D  -isysroot $(PG_SYSROOT)

instead of

CPPFLAGS =3D  -isysroot /Applications/Xcode.app/Contents/Developer/Platfor=
ms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk =


thus making it a bit simpler to override that path at build time.
But I'm not sure that that really moves the goalposts very far for you
in terms of ease-of-use, and anyway it might just be greasing the skids
to a non-working extension.

			regards, tom lane