From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
cc: Paul A Jungwirth <pj@illuminatedcomputing.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Inline non-SQL SRFs using SupportRequestSimplify
In-reply-to: 
 <CAFj8pRAH17WO_d9nUWAsV8MXVAVC18Jmn7f+KxGfakEHFY33Xg@mail.gmail.com>
References: <09de6afa-c33d-4d94-a5cb-afc6cea0d2bb@illuminatedcomputing.com>
 <ffd7937d-190c-4f09-9418-5345728b45c4@iki.fi>
 <1755478.1722020334@sss.pgh.pa.us>
 <956f8a6f-32a7-49ab-92a3-dca5c8afe112@illuminatedcomputing.com>
 <1466725.1725381721@sss.pgh.pa.us>
 <33b10538-2c88-4278-a65f-0c1e6f265cb7@illuminatedcomputing.com>
 <737313.1752528083@sss.pgh.pa.us>
 <CA+renyXxanvX8rnrqTNkZt1r9=rm59MHSG4DDVfsV2aUGe3dUQ@mail.gmail.com>
 <440458.1763858681@sss.pgh.pa.us>
 <CAFj8pRAH17WO_d9nUWAsV8MXVAVC18Jmn7f+KxGfakEHFY33Xg@mail.gmail.com>
Comments: In-reply-to Pavel Stehule <pavel.stehule@gmail.com>
	message dated "Tue, 02 Dec 2025 06:52:21 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <295576.1764655552.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Tue, 02 Dec 2025 01:05:52 -0500
Message-ID: <295577.1764655552@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/295577.1764655552%40sss.pgh.pa.us>
Precedence: bulk

Pavel Stehule <pavel.stehule@gmail.com> writes:
> ne 23. 11. 2025 v 1:45 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
>> So after some thought I renamed inline_set_returning_function to
>> inline_function_in_from, and made a bunch of other changes in names
>> and comments to line up with that.

> I checked this patch, and I think so using the body of the
> function foo_from_bar is very confusing.

Perhaps that example could use more documentation effort ...

> More correct form should be
>   RAISE EXCEPTION 'halt - should not be executed directly';

... but I don't agree with this at all.  We specifically do
not guarantee that replacement via SupportRequestSimplify
will be honored, and I think the same must be true for
SupportRequestInlineInFrom.  Otherwise we risk breaking
who-knows-how-many third-party tools, as well as cases
where the optimizer declines to inline (eg, because there
are volatile arguments).  Besides, what's the value?

			regards, tom lane