Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1glbUk-00082P-KG
	for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jan 2019 15:28:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1glbUi-0002hr-Io
	for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jan 2019 15:28:12 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1glbUi-0002hk-Bi
	for pgsql-hackers@lists.postgresql.org; Mon, 21 Jan 2019 15:28:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1glbUf-0003Pw-Rj
	for pgsql-hackers@postgresql.org; Mon, 21 Jan 2019 15:28:11 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0LFRu3J029577;
	Mon, 21 Jan 2019 10:27:56 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andreas Karlsson <andreas@proxel.se>
cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Andrew Gierth <andrew@tao11.riddles.org.uk>,
        David Fetter <david@fetter.org>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Early WIP/PoC for inlining CTEs
In-reply-to: <5715d93e-6ebc-be17-c2c3-56a873100a38@proxel.se>
References: <dccb37dd-2f52-dbd7-a4c4-72a5853f4838@proxel.se>
 <e02af96a-3e25-5de4-09a4-a7ebf3452184@proxel.se>
 <8810.1542402910@sss.pgh.pa.us>
 <d4daf011-01cf-6bf9-3f15-85ae1572e909@proxel.se>
 <87r2dxrw1z.fsf@news-spur.riddles.org.uk>
 <d0619160-10af-dcc9-4e7d-57845b92570c@proxel.se>
 <CAEepm=2x3kJ5AdkKmEf_ODAZm7+e=7DW1u-+ZwfncWvd8xDaiA@mail.gmail.com>
 <CA+Tgmob=Dpje+oGCYgJCoUok=iPQarGjPqRLYS1qKzChkFfKcA@mail.gmail.com>
 <20190111181934.g5qig23o7rxubnjt@alap3.anarazel.de>
 <CAEepm=2n8hChj548H0R5g5JAx3cokpZwTqRzYhN2oVGqBONwOA@mail.gmail.com>
 <20190111190403.77ye7m5mxypxsf4l@alap3.anarazel.de>
 <CA+TgmobVMPX1wJxPaRQ=FZBzp-AQ=JWK=bzxztqwj=MsOsrnrA@mail.gmail.com>
 <00818be9-2f63-f584-efcd-d97ee0662905@proxel.se>
 <CA+TgmoapASa3RQi=DuSikPoPF4363czSD8KxbOxsfW5XmO3WpQ@mail.gmail.com>
 <5715d93e-6ebc-be17-c2c3-56a873100a38@proxel.se>
Comments: In-reply-to Andreas Karlsson <andreas@proxel.se>
	message dated "Mon, 21 Jan 2019 14:40:34 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29575.1548084476.1@sss.pgh.pa.us>
Date: Mon, 21 Jan 2019 10:27:56 -0500
Message-ID: <29576.1548084476@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andreas Karlsson <andreas@proxel.se> writes:
> I have a minor biksheddish question about the syntax.
> You proposed:
> WITH cte_name [[NOT] MATERIALIZED] AS (query) main_query
> While Andrew proposed:
> WITH cte_name AS [[NOT] MATERIALIZED] (query) main_query
> Do people have any preference between these two?

FWIW, I'd independently thought that the latter is more readable,
and probably less likely to have syntax problems with future
extensions (since AS is already fully reserved).  Didn't get
around to mentioning it yet, but +1 for putting AS first.

			regards, tom lane