From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Peter Eisentraut <peter@eisentraut.org>,
        Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
        Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
        Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com,
        Alexander Lakhin <exclusion@gmail.com>
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
In-reply-to: <ZoNId8GifUS4TlgG@paquier.xyz>
References: <202403261105.6o4ff4d6qagc@alvherre.pgsql> <202403211207.hfyirjweshbh@alvherre.pgsql> <ZgNSQraRJ4vWe6KI@pryzbyj2023> <ZkyivySXnbvOogZz@pryzbyj2023> <ZmEGMz7TC8SOIUpn@paquier.xyz> <ZoNId8GifUS4TlgG@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 02 Jul 2024 09:23:19 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2969206.1719880817.1@sss.pgh.pa.us>
Date: Mon, 01 Jul 2024 20:40:17 -0400
Message-ID: <2969207.1719880817@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2969207.1719880817%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jun 06, 2024 at 09:43:45AM +0900, Michael Paquier wrote:
>> Not sure that this is a must-have.  It is nice to have, but extra
>> information is a new feature IMO.  Any extra opinions?

> Hearing nothing, I've applied that on HEAD now that v18 is open.

While this won't actually fail against a v10 or v11 server, it won't
show anything useful either (because relam is zero for heaps in
pre-v12 versions).  Perhaps there should be a check to only add the
extra column if server >= v12?

			regards, tom lane